GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Engine process by Domonion · Pull Request #1022 · UnitTestBot/UTBotJava

Conversation

@Domonion

@Domonion Domonion commented Sep 28, 2022

Copy link
Copy Markdown
Collaborator

Moved engine process out of the main idea process. Changes include:

  1. Reactive settings
  2. Removing all JDK9+ api calls to support out-of-the process execution on JDK8
  3. Refactored client protocol initialization, ClientProcessBuilder introduced
  4. Big refactoring

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Domonion
Domonion requested review from CaelmBleidd, SBOne-Kenobi, alisevych, denis-fokin and korifey September 28, 2022 07:19
@alisevych
alisevych requested review from Markoutte and sergeypospelov September 28, 2022 13:31
sergeypospelov
sergeypospelov reviewed Sep 28, 2022
View reviewed changes
Comment thread utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/generator/UtTestsDialogProcessor.kt Outdated
val (methods, className) = ReadAction.nonBlocking<Pair<List<ExecutableId>, String?>> {
val canonicalName = srcClass.canonicalName
// todo how bad is it?
val clazz = classLoader.loadClass(canonicalName).kotlin

@sergeypospelov sergeypospelov Sep 28, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't allow running project with JDK-17 on IDEA with JDK-11.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@alisevych

alisevych commented Sep 28, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I've built plugin from this branch and installed it on IntelliJ IDEA 2022.1.4
Found a bug:
Error popup "Failed to save tests report". When OK is pressed SARIF-file is saved.
image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alisevych

alisevych commented Sep 28, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Also one more bug found by @Markoutte :
Cancel Test generation is ignored - process continues up to the end.
image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Markoutte
Markoutte reviewed Sep 28, 2022
View reviewed changes
Comment thread utbot-framework/src/main/kotlin/org/utbot/framework/process/generated/.rdgen Resolved

Uh oh!

There was an error while loading. Please reload this page.
Markoutte
Markoutte reviewed Sep 28, 2022
View reviewed changes
Comment thread utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/process/ChildProcess.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.
@alisevych

alisevych commented Sep 28, 2022

Copy link
Copy Markdown
Member

Found issue:
Concrete execution logs contain many debug information.
Log on test generation for Recursion class weights 1,5 GB (!)
Domonion reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Domonion added 7 commits September 29, 2022 14:47
@Domonion
[engine-process]
fb4b6a3 
Moved engine process out of the main idea process. Changes include:
1. Reactive settings
2. Removing all JDK9+ api calls to support out-of-the process execution
   on JDK8
3. Refactored client protocol initialization, ClientProcessBuilder
   introduced
4. Big refactoring
@Domonion
[utbot-rd]
104b26a 
simple fixes
@Domonion
[utbot-rd]
57e30a8 
logs for ci, commit will be reverted
@Domonion
[utbot-rd]
1ecad23 
deadlock fix
@Domonion
[utbot-rd]
51d5e92 
more jdk api fixes
@Domonion
[utbot-rd]
f071d40 
removed reflexion, proxied all reflection calls to another process, some fixes, removed test generation report, sarif generation proxied to another process, fixed logs
@Domonion
[utbot-rd]
ef7a1ab 
enabled test generation report, optimized kryo serialization - UtMethodTestCase no more send to main process, access it through testSetsId
@Domonion
Domonion force-pushed the kononov-engine-process-idea branch from f376b1a to ef7a1ab Compare October 3, 2022 13:08
Domonion added 2 commits October 3, 2022 16:47
@Domonion
Merge branch 'main' into kononov-engine-process-idea
a8ff3af
@Domonion
idea 17
067da31 
[utbot-rd]
threading fix

[utbot-rd]
merge fixes
@Domonion
Domonion force-pushed the kononov-engine-process-idea branch from 4d0c8f0 to 067da31 Compare October 4, 2022 07:36
@Domonion

Domonion commented Oct 4, 2022

Copy link
Copy Markdown
Collaborator Author

rolling to #1067
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Domonion Domonion closed this Oct 4, 2022
@Domonion
Domonion deleted the kononov-engine-process-idea branch December 6, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Markoutte Markoutte Markoutte left review comments
@sergeypospelov sergeypospelov sergeypospelov left review comments
@SBOne-Kenobi SBOne-Kenobi Awaiting requested review from SBOne-Kenobi
@alisevych alisevych Awaiting requested review from alisevych
@CaelmBleidd CaelmBleidd Awaiting requested review from CaelmBleidd
@denis-fokin denis-fokin Awaiting requested review from denis-fokin
@korifey korifey Awaiting requested review from korifey

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Domonion @alisevych @Markoutte @sergeypospelov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.