GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enabling action and TestNg version depends on the project SDK by EgorkaKulikov · Pull Request #1209 · UnitTestBot/UTBotJava

Conversation

@EgorkaKulikov

@EgorkaKulikov EgorkaKulikov commented Oct 21, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Description

Projects with JDK 8 require TestNg < 7.6.0 version
Projects with JDK 11 and higher require TestNg >= 7.6.0 version

An ability to select a version of TestNg depending on the current JDK is supported.

Fixes # (309)

Also Generate tests action is disabled for classes without source module.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual Scenario

Try to generate tests with TestNg for projects with JDK8 and JDK11

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EgorkaKulikov
EgorkaKulikov marked this pull request as ready for review October 21, 2022 12:56
@EgorkaKulikov
EgorkaKulikov force-pushed the egor/testng_java8 branch from 7a1bbfa to 74a0623 Compare October 21, 2022 13:00
@EgorkaKulikov
EgorkaKulikov requested a review from Vassiliy-Kudryashov October 21, 2022 13:02
@EgorkaKulikov EgorkaKulikov changed the title Different versions of TestNg can be installed into project Enabling action and TestNg version depends on the project sdk Oct 21, 2022
@EgorkaKulikov EgorkaKulikov changed the title Enabling action and TestNg version depends on the project sdk Enabling action and TestNg version depends on the project SDK Oct 21, 2022
@EgorkaKulikov
Different versions of TestNg can be installed into project
8fbf89b
@EgorkaKulikov
EgorkaKulikov force-pushed the egor/testng_java8 branch from 72270e1 to 8fbf89b Compare October 21, 2022 14:33
Vassiliy-Kudryashov
Vassiliy-Kudryashov approved these changes Oct 21, 2022
View reviewed changes
@EgorkaKulikov
EgorkaKulikov merged commit 177859a into main Oct 21, 2022
@EgorkaKulikov
EgorkaKulikov deleted the egor/testng_java8 branch October 21, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vassiliy-Kudryashov Vassiliy-Kudryashov Vassiliy-Kudryashov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@EgorkaKulikov @Vassiliy-Kudryashov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.