GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Solver optimizations by CaelmBleidd · Pull Request #1265 · UnitTestBot/UTBotJava

Conversation

@CaelmBleidd

@CaelmBleidd CaelmBleidd commented Oct 31, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Description

This request improves performance of the engine by removing some constraints from the queries to a solver.

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Automated Testing

The whole pipeline is working fine, runs using contestEstimator didn't find any new issues

Manual Scenario

It was not tested manually.

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@CaelmBleidd
CaelmBleidd requested review from Damtev and sergeypospelov October 31, 2022 10:04
@CaelmBleidd
CaelmBleidd force-pushed the caelmbleidd/optimizations branch from 5e3103c to 679573d Compare October 31, 2022 10:29
@CaelmBleidd
Solver optimizations
9a08b82
@CaelmBleidd
CaelmBleidd force-pushed the caelmbleidd/optimizations branch from 679573d to 9a08b82 Compare October 31, 2022 11:44
sergeypospelov
sergeypospelov requested changes Nov 1, 2022
View reviewed changes
Comment thread utbot-framework/src/main/kotlin/org/utbot/engine/DataClasses.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

CaelmBleidd added 2 commits November 1, 2022 11:50
@CaelmBleidd
Soot class comparison fix
f4b7a76
@CaelmBleidd
Add a comment about fallbacks for types
bf326f3
Damtev
Damtev approved these changes Nov 1, 2022
View reviewed changes

@Damtev Damtev left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread utbot-framework/src/main/kotlin/org/utbot/engine/Resolver.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread utbot-framework/src/main/kotlin/org/utbot/engine/pc/Z3TranslatorVisitor.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread utbot-framework/src/main/kotlin/org/utbot/engine/pc/Z3TranslatorVisitor.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

@CaelmBleidd
Review fixes
a38d250
@CaelmBleidd
CaelmBleidd requested a review from sergeypospelov November 1, 2022 04:44
sergeypospelov
sergeypospelov approved these changes Nov 1, 2022
View reviewed changes
@CaelmBleidd
CaelmBleidd merged commit 1115aad into main Nov 1, 2022
@CaelmBleidd
CaelmBleidd deleted the caelmbleidd/optimizations branch November 1, 2022 07:00
@alisevych alisevych mentioned this pull request Nov 1, 2022
TreeSet tests contain too much reflection with system classes #1282
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergeypospelov sergeypospelov sergeypospelov approved these changes
@Damtev Damtev Damtev approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@CaelmBleidd @sergeypospelov @Damtev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.