GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixed FileNotFoundExecption during JavaParser work by amandelpie · Pull Request #1303 · UnitTestBot/UTBotJava

Conversation

@amandelpie

@amandelpie amandelpie commented Nov 3, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Description

Fixes #1227 #1204

The main problem was the following: JavaParser tries to parse ZipEntry in zip archive with JDK sources.
ZipEntry is not a file.

To filter this situation, we decided to ignore these zipped sources from the standard library. In reality, we ignored it before @Domonion changes in the #1151 PR.

We extended our scope and failed when faced with these issues.

The proposed solution helps to avoid situation with parsing of non-existing files and also improves the logging for some edge situations.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual Scenario

One of scenarios is described also in the ticket #1204

Checklist (remove irrelevant options):

This is the author self-check list

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • All tests pass locally with my changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@amandelpie
Added a solution
e4b8f4c
@amandelpie
amandelpie marked this pull request as ready for review November 3, 2022 13:15
@amandelpie
Merge branch 'main' into amandelpie/feature-1227
43ac2e2
denis-fokin
denis-fokin reviewed Nov 7, 2022
View reviewed changes
Comment thread utbot-summary/src/main/kotlin/org/utbot/summary/Summarization.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

denis-fokin
denis-fokin approved these changes Nov 7, 2022
View reviewed changes
@amandelpie
amandelpie merged commit 5cc9800 into main Nov 7, 2022
@amandelpie
amandelpie deleted the amandelpie/feature-1227 branch November 7, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denis-fokin denis-fokin denis-fokin approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Summaries are not generated due to FileNotFoundException

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@amandelpie @denis-fokin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.