GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Treat Kotlin getters/setters as KnownImplicitlyDeclaredMethods #1338 #1339 by volivan239 · Pull Request #1341 · UnitTestBot/UTBotJava

Conversation

@volivan239

@volivan239 volivan239 commented Nov 9, 2022

Copy link
Copy Markdown
Collaborator

Description

Added filtering of Kotlin autogenerated getters/setters to ExecutableId.isKnownImplicitlyDeclaredMethod. Also added some checks to prevent using Kotlin reflection on facade classes -- see KT-16479

Fixes #1338, #1339

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual Scenario

Launched cli on examples from #1338 and #1339 -- works as expected

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@volivan239
volivan239 requested review from Damtev and viktoriia-fomina November 9, 2022 14:21
@volivan239
Treat Kotlin getters/setters as KnownImplicitlyDeclaredMethods in cli…
336e03e 
…/contest estimator
@volivan239
volivan239 force-pushed the volivan239/fxing_kotlin_cli branch from fba45a1 to 336e03e Compare November 9, 2022 14:27
@volivan239 volivan239 linked an issue Nov 9, 2022 that may be closed by this pull request
Support top-level Kotlin functions in CLI #1339
Closed
@volivan239
volivan239 marked this pull request as ready for review November 9, 2022 14:34
Damtev
Damtev approved these changes Nov 10, 2022
View reviewed changes

@Damtev Damtev left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@volivan239
volivan239 merged commit 1320f17 into main Nov 11, 2022
@volivan239
volivan239 deleted the volivan239/fxing_kotlin_cli branch November 11, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Damtev Damtev Damtev approved these changes
@viktoriia-fomina viktoriia-fomina Awaiting requested review from viktoriia-fomina

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support top-level Kotlin functions in CLI Tests for autogenerated Kotlin getters/setters shouldn't be generated in cli and contest estimator

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@volivan239 @Damtev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.