GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Rd & logs refactoring by Domonion · Pull Request #1399 · UnitTestBot/UTBotJava

Conversation

Domonion commented Nov 18, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

Description

Multiple refactorings and enhacements for process starting.
Removed UtSettings.logConcreteExecutionErrors and UtSettings.engineProcessLogLevel switches.
Logs for engine and concrete executor processes are always enabled.
Switched log configuration to utbot-intellij/log4j2.xml.
Use UtSettings#getIdeaProcessLogConfigFile from ~/.utbot/settings.properties to configure logs for engine and concrete executor processes without rebuilding plugin.

Enabling suspend and port choosing by utsettings.
Run configurations for debugging.
Instant process death detection.
Orphan processes termination system.
Some text loading optimization.
ChildProcess -> InstrumentedProcess.
Rd-based UtSettings for InstrumentedProcess.

partially solves #1365
fix #1427

Type of Change

Refactoring (typos and non-functional changes)
New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Domonion requested review from denis-fokin and korifey

November 22, 2022 09:20

korifey approved these changes

Nov 22, 2022

View reviewed changes

denis-fokin reviewed

Nov 22, 2022

View reviewed changes

Comment thread

utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

denis-fokin reviewed

Nov 22, 2022

View reviewed changes

Comment thread

utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

denis-fokin reviewed

Nov 22, 2022

View reviewed changes

Comment thread

utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

denis-fokin reviewed

Nov 22, 2022

View reviewed changes

Comment thread

utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

denis-fokin reviewed

Nov 22, 2022

View reviewed changes

Comment thread

utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

denis-fokin reviewed

Nov 22, 2022

View reviewed changes

Comment thread

utbot-framework-api/src/main/kotlin/org/utbot/framework/UtSettings.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

sergeypospelov approved these changes

Nov 23, 2022

View reviewed changes

Comment thread

docs/contributing/InterProcessDebugging.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

docs/RD for UnitTestBot.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/rd/InstrumentedProcess.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/ConcreteExecutor.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/generator/CodeGenerationController.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

utbot-rd/src/main/kotlin/org/utbot/rd/ClientProcessUtil.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

utbot-rd/src/main/kotlin/org/utbot/rd/RdSettingsContainer.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

utbot-rd/src/main/kotlin/org/utbot/rd/UtRdCoroutineScope.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

sergeypospelov self-requested a review

November 23, 2022 07:00

sergeypospelov requested changes

Nov 23, 2022

View reviewed changes

sergeypospelov left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to missclick :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Domonion commented Nov 25, 2022

Copy link

Copy Markdown

Collaborator Author

@denis-fokin @sergeypospelov @olganaumenko please, read design docs

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Domonion force-pushed the kononov-rd-refactoring-1 branch from b79d242 to f02b9f2 Compare

November 25, 2022 10:29

Domonion requested review from denis-fokin, olganaumenko and sergeypospelov

November 25, 2022 10:39

Domonion force-pushed the kononov-rd-refactoring-1 branch from f02b9f2 to 14ad3db Compare

November 25, 2022 13:02

denis-fokin approved these changes

Nov 25, 2022

View reviewed changes

Comment thread

utbot-framework/src/main/kotlin/org/utbot/framework/codegen/domain/Domain.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

utbot-framework/src/main/kotlin/org/utbot/framework/concrete/UtExecutionInstrumentation.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

...strumentation/src/main/kotlin/org/utbot/instrumentation/process/InstrumentedProcessRunner.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

.../src/main/kotlin/org/utbot/instrumentation/rd/generated/InstrumentedProcessRoot.Generated.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

utbot-rd/src/main/kotlin/org/utbot/rd/UtRdUtil.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

utbot-rd/src/main/kotlin/org/utbot/rd/UtRdUtil.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

utbot-rd/src/main/kotlin/org/utbot/rd/exceptions/InstantProcessDeathException.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

utbot-rd/src/main/kotlin/org/utbot/rd/exceptions/InstantProcessDeathException.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

docs/RD for UnitTestBot.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Domonion force-pushed the kononov-rd-refactoring-1 branch 2 times, most recently from da2882e to d211adf Compare

November 25, 2022 15:09

Domonion added 6 commits

November 25, 2022 18:10


          [rd-refactoring]

1e34350

Multiple refactorings and enhacements for process starting.
Removed UtSettings.logConcreteExecutionErrors and UtSettings.engineProcessLogLevel switches.
Logs for engine and concrete executor processes are always enabled.
Switched log configuration to utbot-intellij/log4j2.xml.
Use UtSettings#getIdeaProcessLogConfigFile from ~/.utbot/settings.properties to configure logs for engine and concrete executor processes without rebuilding plugin.


          [rd-refactoring]

a2c9b5a

Enabling suspend and port choosing by utsettings
Run configurations for debugging
Instant process death detection
Orphan processes termination system
Some text loading optimization
ChildProcess -> InstrumentedProcess
Rd-based UtSettings for InstrumentedProcess


          [rd-refactoring]

124b14c

Rd version bump, model regeneration typos and small adjustments


          [design-docs]

8d172d5

Rewriting design docs for inter process debugging and rd.
Completely new design doc go inter process logging


          [rd-factoring]

review fix


          [rd-factoring]

c7b4b9b

review fix

Domonion force-pushed the kononov-rd-refactoring-1 branch from d211adf to c7b4b9b Compare

November 25, 2022 15:11


          [rd-factoring]

f56ace2

debug run configurations fix

Domonion enabled auto-merge (squash)

November 25, 2022 16:43

sergeypospelov approved these changes

Nov 26, 2022

View reviewed changes

Comment thread

docs/RD for UnitTestBot.md

		UtBot consists of 3 different processes:
		1. `IDEA process` - the one where plugin part executes. Also can be called `plugin process`, `IDE process`.
		2. `Engine process` - process where unit test generation engine executes.
		3. `InstrumentedProces` - process where concrete execution takes place.

sergeypospelov Nov 26, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	3. `InstrumentedProces` - process where concrete execution takes place.
	3. `InstrumentedProcess` - process where concrete execution takes place.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Domonion merged commit 46cfad6 into main

Nov 26, 2022

Domonion deleted the kononov-rd-refactoring-1 branch

November 26, 2022 03:10

Reviewers

korifey

korifey approved these changes

denis-fokin

denis-fokin approved these changes

sergeypospelov

sergeypospelov approved these changes

olganaumenko

Awaiting requested review from olganaumenko

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rd refactoring

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Domonion commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

How Has This Been Tested?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sergeypospelov left a comment

Choose a reason for hiding this comment

Uh oh!

Domonion commented Nov 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sergeypospelov Nov 26, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Domonion commented Nov 18, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.