GeezerVison is showing github.com — Enable Java 8 for contest estimator by denis-fokin · Pull Request #1711 · UnitTestBot/UTBotJava
Conversation
denis-fokin
commented
Jan 18, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Description
SBST competition requires us generating and running tests with Java 8. While it seems reasonable to switch JAVA_HOME to Java 8, it will break others projects. We have to switch only the project specific to tests generated by the contest estimator.
Type of Change
Please delete options that are not relevant.
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
How Has This Been Tested?
Regression and integration tests
Local run
Automated Testing
CI run
Manual Scenario
- Specify path to Java 8 rt.jar in gradle.properties (jdk8Jar)
- Run contest estimator for spoon project
- Execute :utbot-junit-contest:test task
- Check that IDE shows test run results
Checklist (remove irrelevant options):
This is the author self-check list
- The change followed the style guidelines of the UTBot project
- Self-review of the code is passed
- The change contains enough commentaries, particularly in hard-to-understand areas
- New documentation is provided or existed one is altered
- No new warnings
- New tests have been added
- All tests pass locally with my changes
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes does not bring JDK 8 to Contest Estimator, see Issues tree from #1736. I think its worth adding this changes without jdk8Jar
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
Requested changes must be addressed to merge this pull request.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.