GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable Java 8 for contest estimator by denis-fokin · Pull Request #1711 · UnitTestBot/UTBotJava

Conversation

@denis-fokin

@denis-fokin denis-fokin commented Jan 18, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Description

SBST competition requires us generating and running tests with Java 8. While it seems reasonable to switch JAVA_HOME to Java 8, it will break others projects. We have to switch only the project specific to tests generated by the contest estimator.

Type of Change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Regression and integration tests

Local run

Automated Testing

CI run

Manual Scenario

  1. Specify path to Java 8 rt.jar in gradle.properties (jdk8Jar)
  2. Run contest estimator for spoon project
  3. Execute :utbot-junit-contest:test task
  4. Check that IDE shows test run results

Checklist (remove irrelevant options):

This is the author self-check list

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@denis-fokin
denis-fokin force-pushed the denis-fokin/enable_java8_for_contest_estimator branch 2 times, most recently from 3b71523 to 7fb91a8 Compare January 18, 2023 15:46
@denis-fokin
denis-fokin marked this pull request as draft January 18, 2023 15:55
@denis-fokin
denis-fokin requested a review from Domonion January 19, 2023 07:15
@denis-fokin
denis-fokin force-pushed the denis-fokin/enable_java8_for_contest_estimator branch from 7fb91a8 to e780dbc Compare January 19, 2023 07:17
@denis-fokin
Enable Java 8 for contest estimator
4da0d67
@denis-fokin
denis-fokin force-pushed the denis-fokin/enable_java8_for_contest_estimator branch from e780dbc to 4da0d67 Compare January 19, 2023 08:45
@denis-fokin
denis-fokin marked this pull request as ready for review January 19, 2023 08:46
@Domonion Domonion mentioned this pull request Jan 23, 2023
JaCoCo integration #1736
Open
@alisevych alisevych added ctg-enhancement New feature, improvement or change request comp-contest-estimator Issue is related to contest estimator labels Jan 24, 2023
Domonion
Domonion requested changes Jan 25, 2023
View reviewed changes

@Domonion Domonion left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes does not bring JDK 8 to Contest Estimator, see Issues tree from #1736. I think its worth adding this changes without jdk8Jar

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Domonion Domonion Domonion requested changes

Requested changes must be addressed to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

comp-contest-estimator Issue is related to contest estimator ctg-enhancement New feature, improvement or change request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@denis-fokin @Domonion @alisevych
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.