GeezerVison is showing github.com — Make fuzzer use static methods to create arbitrary objects by IlyaMuravjov · Pull Request #2440 · UnitTestBot/UTBotJava
Conversation
Description
Now fuzzer can use both static methods and constructors to create instances of arbitrary types.
Fixes #2437
How to test
Automated tests
The proposed changes are verified with tests:
utbot-java-fuzzing/src/test/kotlin/org/utbot/fuzzing/JavaFuzzingTest.kt
Self-check list
- I've set the proper labels for my PR (at least, for category and component).
- PR title and description are clear and intelligible.
- I've added enough comments to my code, particularly in hard-to-understand areas.
- The functionality I've repaired, changed or added is covered with automated tests.
- Manual tests have been provided optionally.
- The documentation for the functionality I've been working on is up-to-date.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
|
|
|
private fun findAccessibleCreators(description: FuzzedDescription, classId: ClassId): Sequence<ExecutableId> =
|
|
|
(classId.allConstructors + (classId.jClass.methods
|
|
|
.filter { it.isStatic && it.returnType.id.isSubtypeOf(classId) }
|
Markoutte
Jul 25, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you, please, check what will happen if generics are used? Something like:
class A<T> {
public static A<String> getStringTyped() { return new A<>("Test") }
private A(T value) {};
}
...
public void testedMethod(A<Integer> expected) { ... }
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will erroneously use getStringTyped() to create A<Integer>. I was assuming that java fuzzer doesn't attempt to fully respect generic types here, since similar issue could have been reproduced even before this pull request:
interface A<T> {
T get();
}
class AImpl implements A<String> {
@Override
public String get() {
return "Test";
}
}
...
public void testedMethod(A<Integer> expected) { ... }
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, I tried to fix it with #2451. Please, review it when it is possible. I think same can be done for this PR when 2451 is merged.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
At least 2 approving reviews are required to merge this pull request.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.