GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Add --fuzzing-ratio to CLI by Markoutte · Pull Request #2496 · UnitTestBot/UTBotJava Conversation
| |||||||||||||||||||||||||||||||||||||||||||||||||
| projectRootPath == null -> { | ||
| println("The path to the project root is required to generate a report. Please, specify \"--project-root\" option.") | ||
| } | ||
| sourceCodeFile == null -> { |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we need curly braces here )
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| @@ -149,9 +148,12 @@ class GenerateTestsCommand : | |||
| projectRootPath == null -> { | |||
| println("The path to the project root is required to generate a report. Please, specify \"--project-root\" option.") | |||
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
May be we should not ask specifying but suggest specifying the source code. Otherwise the user may think that it is mandatory for proper work of utility.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The --project-root is mandatory only when --sarif is set. In others cases it is not mandatory
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| .long() | ||
| .default(LONG_GENERATION_TIMEOUT) | ||
|
|
||
| private val fuzzingRation by option( |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Nit: "ration" seems misused here. Consider calling this property fuzzingRatio instead of fuzzingRation.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| private val fuzzingRation by option( | ||
| "--fuzzing-ratio", | ||
| help = "Specify the ratio between symbolic engine and fuzzing" | ||
| ) | ||
| .double() |
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
According to this comment from @tyuldashev, the default is 0.1 fuzzing, 0.9 symbolic. If we take the help text literally, then the default "ratio between symbolic engine and fuzzing" would be 0.9 ÷ 0.1 = 9. But from my understanding of the code, 9 is not a valid value here, and this argument should actually be 0.1 to mimic the default behavior.
Consider revising this option's name and help text to reflect its actual semantics and to document its default behavior. For example:
private val fuzzingFraction by option( "-z", "--fuzzing-fraction", help = "Specifies the fraction of time spent using fuzzing instead of the symbolic engine (default: $DEFAULT_FUZZING_VALUE)" ) .double() .default(DEFAULT_FUZZING_VALUE) .validate { require(it in 0.0 .. 1.0) { "should be between 0.0 and 1.0." } }
where DEFAULT_FUZZING_VALUE is the default value of org.utbot.framework.plugin.api.TestFlow.fuzzingValue: currently 0.1.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
At least 2 approving reviews are required to merge this pull request.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.