GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Implement new approach to create variables in parametrized tests by EgorkaKulikov · Pull Request #547 · UnitTestBot/UTBotJava

Conversation

@EgorkaKulikov

@EgorkaKulikov EgorkaKulikov commented Jul 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Description

Currently parametrized test variables contains a lot of hacks in variable creation process.
For example, expectedResult in method parameters and asserts is represented by to different CgVariable instances
Also there is a strange hack with wrappers for actual variable.

We need to remove all this ugly hacks.

Also some fixes in deepEquals method related to primitive wrappers are suggested.

Fixes # (562)

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Automated Testing

utbot-samples and ContestEstimator

Manual Scenario

Smoke regression testing of Codegen

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EgorkaKulikov
EgorkaKulikov force-pushed the egor/parametrized_tests_variables branch 3 times, most recently from 82decc4 to 275697c Compare July 20, 2022 08:30
EgorkaKulikov added 3 commits July 20, 2022 12:42
@EgorkaKulikov
Refactor TestCaseGenerator and CodeGenerator
777a77d
@EgorkaKulikov
Tmp
87ca3db
@EgorkaKulikov
Additional work
08928ee
@EgorkaKulikov
EgorkaKulikov force-pushed the egor/parametrized_tests_variables branch from 275697c to 08928ee Compare July 20, 2022 09:42
@EgorkaKulikov
EgorkaKulikov marked this pull request as ready for review July 20, 2022 09:43
@EgorkaKulikov
EgorkaKulikov requested a review from ArsenHD July 20, 2022 09:44
ArsenHD
ArsenHD reviewed Jul 20, 2022
View reviewed changes
Comment thread utbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/Api.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread utbot-framework/src/main/kotlin/org/utbot/framework/assemble/AssemblePrimitiveWrapper.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread ...rk/src/main/kotlin/org/utbot/framework/codegen/model/constructor/tree/CgMethodConstructor.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread utbot-framework/src/main/kotlin/org/utbot/framework/codegen/model/tree/CgElement.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread utbot-framework/src/main/kotlin/org/utbot/framework/codegen/model/tree/CgElement.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread utbot-framework/src/main/kotlin/org/utbot/framework/codegen/model/tree/CgElement.kt Resolved

Uh oh!

There was an error while loading. Please reload this page.
@EgorkaKulikov
Apply several fixes
dbbff7c
@EgorkaKulikov
EgorkaKulikov force-pushed the egor/parametrized_tests_variables branch from 17cce95 to dbbff7c Compare July 20, 2022 11:37
ArsenHD
ArsenHD approved these changes Jul 20, 2022
View reviewed changes
@EgorkaKulikov EgorkaKulikov linked an issue Jul 20, 2022 that may be closed by this pull request
Create variables in parametrized tests similarly as in not parametrized #562
Closed
@EgorkaKulikov
EgorkaKulikov enabled auto-merge (squash) July 20, 2022 12:08
@EgorkaKulikov
EgorkaKulikov merged commit 74e7a34 into main Jul 20, 2022
@EgorkaKulikov
EgorkaKulikov deleted the egor/parametrized_tests_variables branch July 20, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArsenHD ArsenHD ArsenHD approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

UTBot Java
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create variables in parametrized tests similarly as in not parametrized

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@EgorkaKulikov @ArsenHD
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.