GeezerVison is showing github.com — Added pre-condition for non-empty paths in the ExecutionMetric to avoid unclear NPE #267 by amandelpie · Pull Request #567 · UnitTestBot/UTBotJava
Conversation
amandelpie
commented
Jul 21, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Description
The ExecutionMetric works with the non-empty paths, but could obtain it sometimes.
I've added pre-condition checks and throw a few exceptions to handle it later and with the correct message.
Fixes #267
Type of Change
- Minor bug fix (non-breaking small changes)
How Has This Been Tested?
Automated Testing
Added a new test to reproduce the condition with empty paths
ExecutionMetricTest.computeWithTwoEmptySteps
Checklist (remove irrelevant options):
- The change followed the style guidelines of the UTBot project
- Self-review of the code is passed
- The change contains enough commentaries, particularly in hard-to-understand areas
- New documentation is provided or existed one is altered
- No new warnings
- New tests have been added
- All tests pass locally with my changes
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
amandelpie
changed the title
Added required pre-condition for the ExecutionMetric to avoid low-level exception #267
Added required pre-condition for the ExecutionMetric to avoid unclear NPE #267
Jul 21, 2022
amandelpie
changed the title
Added required pre-condition for the ExecutionMetric to avoid unclear NPE #267
Added pre-condition for non-empty paths in the ExecutionMetric to avoid unclear NPE #267
Jul 21, 2022
Reviewers
onewhl
onewhl approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.