GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable mixed call stacks when debuggee loads a mono-2.0* dynamic libr… by joncham · Pull Request #7 · Unity-Technologies/UnityMixedCallstack

Conversation

@joncham

@joncham joncham commented Jan 5, 2018

Copy link
Copy Markdown

…ary into the process. We still only process if a file exists on disk with the same process id. Also, enable mixed call stacks for non-main threads.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joncham
Enable mixed call stacks when debuggee loads a mono-2.0* dynamic libr…
e95777a 
…ary into the process. We still only process if a file exists on disk with the same process id. Also, enable mixed call stacks for non-main threads.
@joncham
joncham requested a review from mderoy January 5, 2018 18:15
mderoy
mderoy approved these changes Jan 5, 2018
View reviewed changes
Comment thread UnityMixedCallstackFilter.cs
private static FileStream _fileStream;
private static StreamReader _fileStreamReader;

public void OnLoadComplete(DkmProcess process, DkmWorkList workList, DkmEventDescriptor eventDescriptor)

@mderoy mderoy Jan 5, 2018

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future Cleanup: We could probably remove this window stuff, unless we're planning on logging things to the output window.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@joncham joncham Jan 5, 2018

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but I see we log other info there as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mderoy
mderoy merged commit 4606aab into Unity-Technologies:master Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mderoy mderoy mderoy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@joncham @mderoy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.