GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(PLU-354): remove connector config models from the SDK by awalker4 · Pull Request #341 · Unstructured-IO/unstructured-python-client

Conversation

@awalker4

@awalker4 awalker4 commented May 7, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Summary

  • Replace the typed unions in CreateSourceConnectorConfig, CreateDestinationConnectorConfig, UpdateSourceConnectorConfig, UpdateDestinationConnectorConfig, and the *ConnectorInformation configs with Dict[str, Any].
  • Delete the per-connector config models and their docs (e.g. S3SourceConnectorConfig, AzureDestinationConnectorConfig, OpenSearchConnectorConfig, …).
  • Bump version to 0.44.0 and add a breaking-change changelog entry.

This decouples the SDK from backend connector schemas — adding/removing fields on a connector no longer requires an SDK release.

These were deprecated in our docs last year. None of our SDK snippets use them.

Test plan

  • CI green
  • Smoke: create a source connector with a plain dict config against SND and confirm the request goes through

Note

Medium Risk
This is a breaking change to the SDK surface area: connector config fields switch from typed models/unions to Dict[str, Any], and many generated connector config classes/docs are removed, which may break downstream type checks and runtime imports.

Overview
Decouples connector configuration from generated SDK models. Connector config fields for create/update and *ConnectorInformation responses now use Dict[str, Any] instead of per-connector typed unions/models.

Removes the generated connector config model classes and their documentation, updates contract tests to assert config is a dict, and bumps the SDK version to 0.44.0 with a breaking-change entry in CHANGELOG.md (plus release metadata in RELEASES.md).

Reviewed by Cursor Bugbot for commit eb0ae92. Bugbot is set up for automated code reviews on this repo. Configure here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
awalker4 and others added 3 commits May 7, 2026 15:36
@awalker4 @claude
feat(PLU-354): remove connector config models from the SDK
c16a209 
Replace the typed unions in CreateSourceConnectorConfig,
CreateDestinationConnectorConfig, etc. with Dict[str, Any] and delete the
generated per-connector config models. New connector fields work without
an SDK upgrade.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@awalker4
fix tests
b8d9d3f
@awalker4
trigger a publish by touching release file
eb0ae92
jordan-homan
jordan-homan reviewed May 7, 2026
View reviewed changes
Comment thread docs/models/shared/updatesourceconnector.md

| Field | Type | Required | Description |
| ---------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------- |
| `config` | [shared.UpdateSourceConnectorConfig](../../models/shared/updatesourceconnectorconfig.md) | :heavy_check_mark: | N/A | No newline at end of file

@jordan-homan jordan-homan May 7, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are most of these getting deleted but some staying? guessing the connector-specific ones are being deleted but not all?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@awalker4 awalker4 May 7, 2026

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, just the generic classes should stay, and they'll just wrap a dict. So we may be able to clean those up too longer term.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/unstructured_client/models/shared/astradbconnectorconfig.py
@@ -1,83 +0,0 @@
"""Code generated by Speakeasy (https://speakeasy.com). DO NOT EDIT."""

@jordan-homan jordan-homan May 7, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all of these deletes a breaking change in any way? Is there a chance that customers are using these files on their side that will now break if they upgrade the package?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@awalker4 awalker4 May 7, 2026

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally! We've had a deprecation notice since like September. So none of our live examples use these classes. If someone has a real old client, hopefully they'll find that migration guide. I'll make a docs pr to note that they're fully removed once this goes out.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jordan-homan
jordan-homan approved these changes May 7, 2026
View reviewed changes
@awalker4
awalker4 merged commit 3577cd6 into main May 7, 2026
25 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@awalker4
awalker4 deleted the austin/plu-354-delete-connector-config-models-from-the-sdk branch May 7, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jordan-homan jordan-homan jordan-homan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@awalker4 @jordan-homan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.