GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Disallow database reload, use FileMetadata::ReopenMovedDatabase · Vector35/binaryninja-api@b03e431

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • binaryninjaapi.h
  • binaryninjacore.h
  • database.cpp
  • rust/src
    • database.rs
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎binaryninjaapi.h‎

Copy file name to clipboardExpand all lines: binaryninjaapi.h
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3275,9 +3275,8 @@ namespace BinaryNinja {
32753275
DataBuffer ReadGlobalData(const std::string& key) const;
32763276
void WriteGlobalData(const std::string& key, const DataBuffer& val);
32773277

3278+
BN_DEPRECATED("Use FileMetadata::ReopenMovedDatabase")
32783279
void ReloadConnection();
3279-
bool ReloadConnection(const std::string& path);
3280-
32813280
Ref<KeyValueStore> ReadAnalysisCache() const;
32823281
void WriteAnalysisCache(Ref<KeyValueStore> val);
32833282
};
Collapse file

‎binaryninjacore.h‎

Copy file name to clipboardExpand all lines: binaryninjacore.h
+2-4Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,14 @@
3737
// Current ABI version for linking to the core. This is incremented any time
3838
// there are changes to the API that affect linking, including new functions,
3939
// new types, or modifications to existing functions or types.
40-
#define BN_CURRENT_CORE_ABI_VERSION 180
40+
#define BN_CURRENT_CORE_ABI_VERSION 181
4141

4242
// Minimum ABI version that is supported for loading of plugins. Plugins that
4343
// are linked to an ABI version less than this will not be able to load and
4444
// will require rebuilding. The minimum version is increased when there are
4545
// incompatible changes that break binary compatibility, such as changes to
4646
// existing types or functions.
47-
#define BN_MINIMUM_CORE_ABI_VERSION 179
47+
#define BN_MINIMUM_CORE_ABI_VERSION 181
4848

4949
#define BN_DEMANGLER_MSVC "MS"
5050
#define BN_DEMANGLER_GNU3 "GNU3"
@@ -4709,8 +4709,6 @@ extern "C"
47094709
BINARYNINJACOREAPI bool BNWriteDatabaseGlobal(BNDatabase* database, const char* key, const char* val);
47104710
BINARYNINJACOREAPI BNDataBuffer* BNReadDatabaseGlobalData(BNDatabase* database, const char* key);
47114711
BINARYNINJACOREAPI bool BNWriteDatabaseGlobalData(BNDatabase* database, const char* key, BNDataBuffer* val);
4712-
BINARYNINJACOREAPI void BNDatabaseReloadConnection(BNDatabase* database);
4713-
BINARYNINJACOREAPI bool BNDatabaseReloadConnectionToPath(BNDatabase* database, const char* path);
47144712
BINARYNINJACOREAPI BNKeyValueStore* BNReadDatabaseAnalysisCache(BNDatabase* database);
47154713
BINARYNINJACOREAPI bool BNWriteDatabaseAnalysisCache(BNDatabase* database, BNKeyValueStore* val);
47164714
BINARYNINJACOREAPI bool BNSnapshotHasData(BNDatabase* db, int64_t id);
Collapse file

‎database.cpp‎

Copy file name to clipboardExpand all lines: database.cpp
+1-10Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -545,16 +545,7 @@ void Database::WriteGlobalData(const std::string& key, const DataBuffer& val)
545545
}
546546

547547

548-
void Database::ReloadConnection()
549-
{
550-
BNDatabaseReloadConnection(m_object);
551-
}
552-
553-
554-
bool Database::ReloadConnection(const std::string& path)
555-
{
556-
return BNDatabaseReloadConnectionToPath(m_object, path.c_str());
557-
}
548+
void Database::ReloadConnection() {}
558549

559550

560551
Ref<KeyValueStore> Database::ReadAnalysisCache() const
Collapse file

‎rust/src/database.rs‎

Copy file name to clipboardExpand all lines: rust/src/database.rs
+2-3Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -198,10 +198,9 @@ impl Database {
198198
unsafe { KeyValueStore::ref_from_raw(NonNull::new(result).unwrap()) }
199199
}
200200

201+
#[deprecated(note = "Use crate::file_metadata::FileMetadata::reopen_moved_database instead")]
201202
/// Closes then reopens the database.
202-
pub fn reload_connection(&self) {
203-
unsafe { BNDatabaseReloadConnection(self.handle.as_ptr()) }
204-
}
203+
pub fn reload_connection(&self) {}
205204

206205
pub fn write_analysis_cache(&self, val: &KeyValueStore) -> Result<(), ()> {
207206
if unsafe { BNWriteDatabaseAnalysisCache(self.handle.as_ptr(), val.handle.as_ptr()) } {

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.