GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix paths with spaces in lit check updater by Rodri5449 · Pull Request #9376 · WebAssembly/binaryen

Conversation

@Rodri5449

@Rodri5449 Rodri5449 commented Nov 9, 2026

Copy link
Copy Markdown

update_lit_checks.py expanded %s/%S/%t before parsing foreach and
didn't quote them for the shell, so paths with spaces broke the updater.
This parses foreach first and quotes expanded paths.

Added test/unit/test_update_lit_checks_paths.py (real updater + wasm-opt
in a directory with spaces): 4 of 5 variants fail before the fix, all pass
after. Tested on Ubuntu (WSL) only.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gemini-code-assist[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction
@Rodri5449
Fix paths with spaces in lit check updater
43be449
@Rodri5449
Rodri5449 requested a review from a team as a code owner November 9, 2026 16:18
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 9, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates scripts/update_lit_checks.py to properly handle and escape paths containing spaces (such as %s, %S, and %t) when executing shell commands, using platform-appropriate quoting (shlex.quote or subprocess.list2cmdline). It also updates the foreach parsing logic to support arguments with spaces and introduces a new unit test suite in test/unit/test_update_lit_checks_paths.py to verify these changes across various scenarios. There are no review comments, and I have no additional feedback to provide.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
tlively
tlively reviewed Nov 9, 2026
View reviewed changes

@tlively tlively left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have lit tests with spaces where this matters? If not, it might be better to just add a TODO comment and save the complexity of making this more robust for now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlively tlively tlively left review comments
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Rodri5449 @tlively
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.