GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — Make runtime downloadables decoding resilient with LossyArray by BalazsSzamody · Pull Request #5 · XcodesOrg/XcodesKit ConversationSummaryThis PR makes Changes
WhyA single invalid runtime entry from upstream should not fail decoding of the full response. Validation
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsIntroduce a reusable LossyArray property wrapper and apply it to DownloadableRuntimesResponse.downloadables so undecodable runtime entries are skipped instead of failing the entire response decode. Co-authored-by: Copilot <[email protected]>
|
There was an error while loading. Please reload this page.
|
@MattKiazyk I don't have enough context to judge where else could this be extended, but I think it could be a good idea to make the decoding a bit more resilient when depending on external models. My thinking is that the downloadable runtimes that can be decoded successfully should still be available even if some runtimes fail to decode.
Feel free to close and ignore this if you don't think it's appropriate. I also thought about failing the Authentication decoding to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.