GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: changes to be compatible with YLT v3 by ohoareau · Pull Request #2 · YellowLabTools/YellowLabTools-lambda-agent

Conversation

@ohoareau

@ohoareau ohoareau commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ohoareau
chore: changes to be compatible with YLT v3
3cab308
@ohoareau
ohoareau force-pushed the main branch from 6899725 to 3cab308 Compare November 8, 2023 07:38
@gmetais

gmetais commented Jan 7, 2024

Copy link
Copy Markdown
Contributor

Hi Olivier,
Happy New Year!

The "Unhandled Promise Rejection" error you encountered is related to a Puppeteer option called headless: "new" that was introduced in Phantomas.

The fix in Phantomas is not ready yet, so I can't update YLT, but I tested a hotfix on my local docker image.

Here is a line I added to your Dockerfile.lambda file (this command adds a double slash at the beginning of the line 35):

RUN sed -i '35 s/^/\/\//' node_modules/phantomas/lib/browser.js

It might be used as a temporary fix. I'll let you know when the final fix is available.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ohoareau and others added 2 commits July 4, 2024 11:48
@ohoareau
fix: add fix for headless new
6d7e2db
@demostanis
fix: remove unneeded analyzeCss.js from phantomas
f0a6880 
this reduces the generated report data's size sent to symphony
(from ~1.1M to 300K on google.com)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ohoareau @gmetais @demostanis
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.