GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Normalize relation case when combining license expressions by codewithfourtix · Pull Request #135 · aboutcode-org/license-expression

Conversation

@codewithfourtix

@codewithfourtix codewithfourtix commented Sep 5, 2026

Copy link
Copy Markdown

Lowercase and mixed-case relations pass validation but then raise KeyError during operator lookup. Normalize the lookup the same way as validation.

Adds coverage for and and or in lowercase, uppercase, and mixed case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codewithfourtix
Normalize relation case when combining license expressions
ea2ecfc 
Signed-off-by: Ali Zulfiqar <[email protected]>
Copilot AI lite review requested due to automatic review settings September 5, 2026 17:02
Copilot started reviewing on behalf of codewithfourtix September 5, 2026 17:03
View session
Copilot AI reviewed Sep 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The fix aligns lookup normalization with existing validation logic and is covered by a focused regression test.

Pull request overview

Fixes a bug in combine_expressions where lowercase or mixed-case relation values (e.g., "and", "Or") would pass validation but fail during operator lookup, and adds tests to ensure case-insensitive relations are accepted.

Changes:

  • Normalize relation to uppercase during the operator lookup in combine_expressions.
  • Add test coverage for and/or relations across lowercase, uppercase, and mixed-case inputs.
File summaries
File Description
src/license_expression/init.py Uppercases relation during AND/OR operator mapping to prevent KeyError for non-uppercase inputs.
tests/test_license_expression.py Adds a regression test ensuring combine_expressions accepts case-insensitive "and"/"or" relations.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@codewithfourtix
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.