GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use non-Webpack-require in evaluated scripts by jclem · Pull Request #134 · actions/github-script

Conversation

@jclem

@jclem jclem commented Apr 21, 2021

Copy link
Copy Markdown
Contributor

Although it probably has no impact on users, we are currently passing the Webpack form of require to the scripts we run. This uses the __non_webpack_require__ const that Webpack provides and declares a const to make TypeScript happy.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jclem
Use non-Webpack-require in evaluated scripts
ddba1b1
@jclem
jclem requested a review from a team April 21, 2021 20:20
@github-actions

github-actions Bot commented Apr 21, 2021

Copy link
Copy Markdown

Hello from actions/github-script! (221cfc7)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jclem

jclem commented Apr 21, 2021

Copy link
Copy Markdown
Contributor Author

Closing in favor of #135
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jclem jclem closed this Apr 21, 2021
@jclem
jclem deleted the non-webpack-require branch April 21, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@jclem
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.