GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update Oktokit dependencies. by IronSean · Pull Request #191 · actions/github-script

Conversation

@IronSean

@IronSean IronSean commented Sep 21, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

A number of oktokit api methods were unavailable in the current version of this action, I bumped them to their highest available non-breaking versions. There's a version 5.. of @octokit/plugin-rest-endpoint-methods but it moves all of the API endpoints from oktokit.* to oktokit.rest.* which would be a breaking change for users of the github-script action, so I leave that as a future exercise.

You can test my fork with ironsean/github-script@v-test.

Fixes #133

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@IronSean
Update Oktokit dependencies.
1084bcb
@IronSean
IronSean requested a review from a team September 21, 2021 21:39
@IronSean IronSean mentioned this pull request Sep 21, 2021
TypeError: github.repos.createOrUpdateEnvironment is not a function - Octokit.js Support up-to-date? #133
Closed
@kimmoahokas

kimmoahokas commented Sep 23, 2021

Copy link
Copy Markdown

Could you update the @actions libraries as well? For example @actions/core 1.5.0 seems to bring quite a lot of new features.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joshmgross

joshmgross commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

👋 Hey @IronSean,

Thanks for this! It can be difficult to review package dependency updates in a safe manner due to the large number of changes.

I've bumped all the minor versions in #192

For fixing #133, we'll need to making some major version updates which will require a new major version of this action.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joshmgross joshmgross closed this Sep 23, 2021
@IronSean

IronSean commented Oct 5, 2021

Copy link
Copy Markdown
Author

@joshmgross I'm 10% disappointed I don't get to count as a contributor since you opened your own PR, but 90% happy that the fix is in and merged quickly 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joshmgross

joshmgross commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

Oops, sorry about that @IronSean.

I added you to https://github.com/actions/github-script/releases/tag/v5.0.0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: github.repos.createOrUpdateEnvironment is not a function - Octokit.js Support up-to-date?

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@IronSean @kimmoahokas @joshmgross
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.