GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Upgrade to the latest version of Octokit by joshmgross · Pull Request #193 · actions/github-script

Conversation

@joshmgross

@joshmgross joshmgross commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

Supports #133, #155, #179
This updates the github authenticated Octokit client available in this action to version 5 of the Octokit client. This change allows users to script using the latest released API.

Since this is a major version update and includes breaking changes, this will come with a v5 release of this action.

The primary breaking change is that REST methods must use github.rest.* instead of github.*. I've added a note to the README for this change and updated our examples.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joshmgross
Upgrade to the latest version of Octokit
5e5d515
@joshmgross
joshmgross requested a review from a team September 23, 2021 21:20
joshmgross added 2 commits September 23, 2021 21:21
@joshmgross
Fix breaking change in workflow test
004e46f
@joshmgross
Update licenses
4e1175c
@github-actions

github-actions Bot commented Sep 23, 2021

Copy link
Copy Markdown

Hello from actions/github-script! (05e1495)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hashtagchris
hashtagchris approved these changes Sep 23, 2021
View reviewed changes

@hashtagchris hashtagchris left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread package.json
"@actions/github": "^4.0.0",
"@actions/glob": "^0.1.2",
"@actions/github": "^5.0.0",
"@actions/glob": "^0.2.0",

@hashtagchris hashtagchris Sep 23, 2021

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't we move to 0.2.0 in #192?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@joshmgross joshmgross Sep 24, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran npm i @actions/glob to create #192, which I thought would bump minor versions but I think 0.y.z has special meaning in semver so it did not bump to the "latest minor version".

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

https://semver.org/#spec-item-4

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joshmgross
joshmgross merged commit 441359b into main Sep 24, 2021
@joshmgross
joshmgross deleted the joshmgross/v5 branch September 24, 2021 16:41
@silvanocerza silvanocerza mentioned this pull request Oct 4, 2021
Bump actions/github-script from 4 to 5 arduino/arduino-cli#1474
Closed
@tunetheweb tunetheweb mentioned this pull request Oct 4, 2021
Fix github scripts to v5 super-linter/super-linter#2032
Merged
1 of 3 tasks
@wata727 wata727 mentioned this pull request Oct 14, 2021
Fix github-script to v5 terraform-linters/tflint-ruleset-azurerm#141
Merged
Echo4F
Echo4F reviewed Oct 31, 2021
View reviewed changes

@Echo4F Echo4F left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@krrrr38 krrrr38 mentioned this pull request Nov 22, 2021
Update readme using github-script@v5 hashicorp/setup-terraform#135
Merged
@per1234 per1234 mentioned this pull request Feb 14, 2022
Bump actions/github-script from 4 to 6 arduino/arduino-cli#1662
Closed
@Sahra2323 Sahra2323 mentioned this pull request Nov 30, 2022
Bump actions/github-script from 3 to 6 github/explore#3413
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Echo4F Echo4F Echo4F left review comments
@hashtagchris hashtagchris hashtagchris approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@joshmgross @hashtagchris @Echo4F
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.