GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update default runtime to node16 by thboop · Pull Request #235 · actions/github-script

Conversation

@thboop

@thboop thboop commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

Node 12 has an end of life on April 30, 2022.

This PR updates the default runtime to node16, rather then node12.

This is supported on all Actions Runners v2.285.0 or later.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
na-jakobs reacted with thumbs up emoji imjohnbo, na-jakobs, and amadejpapez reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 3 reactions
@thboop
Update default runtime to node16
d2ed94b 
Node 12 has an end of life on April 30, 2022.

This PR updates the default runtime to [node16](https://github.blog/changelog/2021-12-10-github-actions-github-hosted-runners-now-run-node-js-16-by-default/), rather then node12. 

This is supported on all Actions Runners v2.285.0 or later.
@thboop
thboop requested a review from a team February 7, 2022 19:00
@jclem

jclem commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

Looks good to me. cc @joshmgross do you think this warrants a major version bump of the action itself? e.g. out-dated self-hosted runners, etc.
joshmgross reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joshmgross

joshmgross commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

This is effectively a breaking change as we'll now be running users' scripts with Node 16 instead of Node 12, so it will require a major version update.

If we're bumping the major version, I'd love to see if we can fit #168 into that release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joshmgross joshmgross mentioned this pull request Feb 9, 2022
Support importing ESM files #168
Closed
joshmgross
joshmgross approved these changes Feb 9, 2022
View reviewed changes
@joshmgross
joshmgross merged commit 41e1ab4 into actions:main Feb 9, 2022
This was referenced Feb 9, 2022
Release v6 of this action #236
Closed
Add an example using ESM import #240
Merged
@hellodword hellodword mentioned this pull request Feb 11, 2022
Why does node version not follow the actions/setup-node? #241
Closed
@joshmgross joshmgross mentioned this pull request Feb 11, 2022
What version of node is used in Actions to run gh-scripts? #76
Closed
@thboop thboop mentioned this pull request Mar 16, 2022
Update Actions to node16 actions/starter-workflows#1469
Merged
11 of 34 tasks
@Sahra2323 Sahra2323 mentioned this pull request Nov 30, 2022
Bump actions/github-script from 3 to 6 github/explore#3413
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@joshmgross joshmgross joshmgross approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@thboop @jclem @joshmgross
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.