GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Draft: Fix API URL on GHES by joshmgross · Pull Request #437 · actions/github-script

Conversation

@joshmgross

@joshmgross joshmgross commented Nov 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

#436

Attempting to reproduce the issue described in #436, and then I will push a change to actually fix it.

- Validating base-url not set respects GITHUB_API_URL
Error: ❌ Expected base-url to equal 'https://my.github-enterprise-server.com/api/v3/', got https://api.github.com/
Error: Process completed with exit code 1.

https://github.com/actions/github-script/actions/runs/6893610162/job/18753569096?pr=437

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joshmgross
joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:16 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Nov 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Hello from actions/github-script! (9a202b7)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joshmgross
Add integration test to validate base-url
4793596
@joshmgross
joshmgross force-pushed the joshmgross/fix-base-url branch from babde17 to 4793596 Compare November 16, 2023 16:20
@joshmgross
joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:20 — with GitHub Actions Inactive
@joshmgross
Fix URLs in base url integration test
8df72cd
@joshmgross
joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:24 — with GitHub Actions Inactive
@joshmgross
Remove trailing / from inputs
b7d983c
@joshmgross
joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:26 — with GitHub Actions Inactive
@joshmgross
Fix bash script
0a6deda
@joshmgross
joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:28 — with GitHub Actions Inactive
@joshmgross
Only set base URL when input is defined
28e4318
@joshmgross
joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:33 — with GitHub Actions Inactive
@joshmgross
Add debug logging for base URL
df3133d
@joshmgross
joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:37 — with GitHub Actions Inactive
@joshmgross
joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:38 — with GitHub Actions Inactive
@joshmgross
Try without base-url entirely
98dabfb
@joshmgross
joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:43 — with GitHub Actions Inactive
@joshmgross joshmgross mentioned this pull request Nov 16, 2023
Goes incorrectly toward api.github.com on Github Enterprise after upgrading to v7 #436
Closed
joshmgross added 2 commits November 16, 2023 18:33
@joshmgross
Include GraphQL URL validations
ec76ce5
@joshmgross
Default to server URL explicitly
4cc0320
@joshmgross
joshmgross temporarily deployed to debug-integration-test November 16, 2023 23:49 — with GitHub Actions Inactive
@joshmgross
Use API URL instead of Server URL
85717e4
@joshmgross
joshmgross temporarily deployed to debug-integration-test November 16, 2023 23:51 — with GitHub Actions Inactive
@joshmgross joshmgross changed the title Draft: Fix base-url overriding GITHUB_API_URL Draft: Fix API URL on GHES Nov 16, 2023
@joshmgross
Avoid setting baseURL if the input is not provided
d09af74
@joshmgross
joshmgross temporarily deployed to debug-integration-test November 17, 2023 15:20 — with GitHub Actions Inactive
@joshmgross joshmgross mentioned this pull request Nov 17, 2023
Avoid setting baseUrl to undefined when input is not provided #439
Merged
@joshmgross

joshmgross commented Nov 17, 2023

Copy link
Copy Markdown
Contributor Author

#439 is shipping this fix and removing the failing integration test, we were able to confirm it works in #436
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joshmgross joshmgross closed this Nov 17, 2023
@joshmgross
joshmgross deleted the joshmgross/fix-base-url branch November 17, 2023 17:06

This branch was previously deployed

1 inactive deployment
debug-integration-test — d09af748 Deployed Nov 17, 2023 by joshmgross
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@joshmgross
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.