GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Define `permissions` in workflows and update actions by joshmgross · Pull Request #531 · actions/github-script

Conversation

@joshmgross

@joshmgross joshmgross commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

I noticed that Dependabot triggered workflows were failing due to permissions not being defined (Dependabot defaults to read only permissions if none are defined) - #523

This PR defines permissions for every workflow, updates action references, and removes the unused stale workflow which I disabled a long time ago.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nschonni reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@joshmgross
Define permissions in workflows and update actions
19e58d8
@joshmgross
joshmgross requested a review from a team as a code owner January 28, 2025 21:52
@joshmgross
joshmgross temporarily deployed to debug-integration-test January 28, 2025 21:52 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jan 28, 2025

Copy link
Copy Markdown

Hello from actions/github-script! (e4e4c24)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nschonni
nschonni reviewed Jan 28, 2025
View reviewed changes
Comment thread .github/actions/install-dependencies/action.yml
using: 'composite'
steps:
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4

@nschonni nschonni Jan 28, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed Dependabot missed this one. I can't recall if there was an issue with nested actions before, but did you want a PR to add the extra job?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@joshmgross joshmgross Jan 28, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that something we can configure with Dependabot or a feature gap?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@nschonni nschonni Jan 28, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I tried it before with a different directory value, but I don't remember if there was an issue https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot#enabling-dependabot-version-updates-for-actions.
I'll send something over, but don't hold this up on my part. I think you'll see it in the Insights>Dependancies tab after if it "works"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@nschonni nschonni Jan 28, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #532

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
johnsudol
johnsudol approved these changes Jan 28, 2025
View reviewed changes
nschonni
nschonni reviewed Jan 28, 2025
View reviewed changes
Comment thread .github/workflows/publish-immutable-actions.yml
- name: Publish
id: publish
uses: actions/[email protected].3
uses: actions/[email protected].4

@nschonni nschonni Jan 28, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the current string that Dependabot fixed in its PR

Suggested change
uses: actions/publish-immutable-action@0.0.4
uses: actions/publish-immutable-action@v0.0.4

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@joshmgross joshmgross Jan 29, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a feature of immutable actions, it will be available more broadly soon - github/roadmap#592

With semantic versioning of actions, the v is optional.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@nschonni nschonni Jan 29, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, just noticed because VSCode also complains about the missing v, since it tries to resolve a tag that doesn't exist (without the v)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@joshmgross joshmgross Jan 29, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'll pass that along to the team

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Nanlonely Nanlonely Jan 30, 2025

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joshmgross
joshmgross merged commit 08caadd into main Jan 29, 2025
@joshmgross
joshmgross deleted the joshmgross/update-workflows branch January 29, 2025 16:20
@nschonni nschonni mentioned this pull request Jan 29, 2025
chore: Bump actions/checkout + actions/setup-node from v3 to v4 #462
Open
@github-actions github-actions Bot mentioned this pull request Sep 4, 2025
Bump actions/github-script from 7 to 8 labrynx/auto_comments#29
Merged
@github-actions github-actions Bot mentioned this pull request Nov 18, 2025
Bump actions/github-script from 7 to 8 senzing-factory/build-resources#236
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Aug 10, 2026
fix(lanes): green mutation-testing, trunk-check, a11y keyboard, scorecard, and quality-gate unit tests KooshaPari/ShareCLI#719
Merged

This branch was previously deployed

1 inactive deployment
debug-integration-test — 19e58d85 Deployed Jan 28, 2025 by joshmgross
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnsudol johnsudol johnsudol approved these changes
+2 more reviewers
@nschonni nschonni nschonni left review comments
@Nanlonely Nanlonely Nanlonely left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@joshmgross @nschonni @johnsudol @Nanlonely
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.