GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replace `@action/github` dependency with latest Octokit by joshmgross · Pull Request #614 · actions/github-script

Conversation

@joshmgross

@joshmgross joshmgross commented Jun 3, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This replaces the dependency of @actions/github with a more direct dependency on Octokit via @octokit/action - https://github.com/octokit/action.js.

@actions/github is on a very old version of Octokit and is preventing users of this action from using the latest GitHub APIs in their scripts:

  • octokit.rest.actions not available #345
  • Update octokit dependency to match online documentation #470
  • AddSubIssue functions missing #519

Using Octokit in a more direct manner will allow this action to keep up date with dependencies in a more timely manner going forward.

This will likely break some user scripts, both from "expected" breaking changes from a multi-version bump of Octokit and unexpected breakages from new or different behavior in @octokit/action or this action that we're not correctly replicating from @actions/github. My hope is that integration tests will catch the more significant scenarios, but we should expect some bugs with the v8 version of this action once it's released - #556.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

elbrenn reacted with eyes emoji
All reactions
  • 👀 1 reaction
joshmgross added 2 commits June 2, 2025 21:46
@joshmgross
Replace @action/github dependency with latest Octokit
f734337
@joshmgross
Remove commented out configuration
0e0b836
joshmgross
joshmgross commented Jun 3, 2025
View reviewed changes
Comment thread tsconfig.json
Comment on lines +4 to +5
"module": "Node16",
"moduleResolution": "node16",

@joshmgross joshmgross Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears all of the newer Octokit libraries require this - https://github.com/octokit/action.js/blob/25f537f58b9d8ee779175a9601f0958b1b2ce6ac/README.md#L33-L37

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread package.json
"author": "GitHub",
"license": "MIT",
"main": "dist/index.js",
"type": "module",

@joshmgross joshmgross Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fairly certain this was required when updating Octokit, I don't think it should impact much since this action isn't consumed as a library.

My one concern is that it somehow impacts the custom require functionality this action implements, but integration tests should catch that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread dist/index.js

@joshmgross joshmgross Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure why the dist is so bloated now

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@joshmgross
Update README to use v8 and octokit by default
b0ee7ad
joshmgross
joshmgross commented Jun 3, 2025
View reviewed changes
Comment thread README.md
retries: 3
script: |
github.rest.issues.get({
octokit.rest.issues.get({

@joshmgross joshmgross Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting the README changes from #557 - with #508 we should steer users towards using octokit as that will be more documentation and AI friendly 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@joshmgross
joshmgross marked this pull request as ready for review June 3, 2025 02:02
@joshmgross
joshmgross requested a review from a team as a code owner June 3, 2025 02:02
@joshmgross joshmgross closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@joshmgross
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.