GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: fix inaccuracies and add missing required flags in action.yml by kranthipoturaju · Pull Request #721 · actions/github-script

Conversation

@kranthipoturaju

@kranthipoturaju kranthipoturaju commented May 25, 2026

Copy link
Copy Markdown

Summary

Corrects inaccuracies and fills documentation gaps in action.yml to accurately reflect the current implementation in src/main.ts and src/retry-options.ts. No behavior or code changes are included.

Changes

  • result output description fixed: Previously stated the result is always "stringified with JSON.stringify", which is only true for result-encoding: json. When result-encoding: string, the output uses String(). Description now covers both paths.
  • result-encoding description improved: Removed the redundant (default "json") phrase (already declared in the default: field) and replaced with the concrete JS functions used for each mode.
  • user-agent description updated: The ACTIONS_ORCHESTRATION_ID environment variable is read at runtime in main.ts and silently appended to the user-agent string. This behavior was entirely undocumented in action.yml.
  • required: false added to all implicitly optional inputs: debug, user-agent, previews, result-encoding, retries, and retry-exempt-status-codes were all optional but lacked the explicit flag. previews in particular had neither a default: nor required: false, making its optionality ambiguous to tooling and readers.

Motivation

action.yml is the primary machine-readable and human-readable contract for this action. Inaccurate descriptions mislead users and tooling (IDE completions, actionlint, documentation generators). The result output description was factually wrong for the string encoding path, and the undocumented ACTIONS_ORCHESTRATION_ID behavior was invisible to users trying to understand or debug user-agent strings in audit logs.

Impact

  • Users: No behavioral change. All input names, defaults, and output names are unchanged—full backward compatibility is preserved.
  • Tooling: actionlint and schema validators now see explicit required: false on all optional inputs, reducing false-positive warnings.
  • Documentation generators: Output description now accurately describes both encoding modes.

Testing

action.yml is a metadata file with no executable logic. The change was validated by:

  1. Confirming each modified field against the corresponding code path in src/main.ts (result-encoding switch, getUserAgentWithOrchestrationId, core.getInput calls).
  2. Verifying no input names, defaults, or output names were altered.
  3. Running git diff to confirm the diff is strictly additive to descriptions and required: false flags with no structural changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Kranthi Poturaju Kranthi Poturaju
docs: fix inaccuracies and add missing required flags in action.yml
c61cde2
Copilot AI review requested due to automatic review settings May 25, 2026 13:33
@kranthipoturaju
kranthipoturaju requested a review from a team as a code owner May 25, 2026 13:33
Copilot AI reviewed May 25, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Documentation and metadata refinements to action.yml: clarifies input/output descriptions and explicitly marks optional inputs as required: false.

Changes:

  • Added required: false to optional inputs for explicitness/consistency.
  • Clarified descriptions for user-agent, result-encoding, and the result output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kranthipoturaju
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.