Description

timfel

opened on Jun 27, 2023

Issue body actions

Description:
I would like to add support for installing GraalPy via setup-python. We are starting to ask people to include support for GraalPy in their packages, and they (reasonably) request to be able to test against GraalPy using their existing workflows using setup-python.

Are you willing to submit a PR?
I have prepared the changes for setup-python, mimicking the PyPy support code. The tests using local mock data pass.

Activity

1. timfel

   added

   feature requestNew feature or request to improve the current logicNew feature or request to improve the current logic

   needs triage

   on Jun 27, 2023
2. dmitry-shibanov commented on Jun 28, 2023

   

   dmitry-shibanov

   on Jun 28, 2023

   Contributor

   More actions

   Hello @timfel. Thank you for your feature request. We'll investigate it.
3. dusan-trickovic

   removed

   needs triage

   on Jun 28, 2023
4. timfel commented on Jun 28, 2023

   

   timfel

   on Jun 28, 2023

   ContributorAuthor

   More actions

   Hello @timfel. Thank you for your feature request. We'll investigate it.

   Thanks. I opened a PR to implement this at #694
5. dusan-trickovic

   added

   needs eyes

   on Jul 12, 2023
6. dusan-trickovic

   linked a pull request that will close this issueAdd GraalPy support #694on Jul 13, 2023
7. dusan-trickovic

   removed a link to a pull requestAdd GraalPy support #694on Jul 13, 2023
8. dusan-trickovic

   linked a pull request that will close this issueAdd GraalPy support #694on Jul 13, 2023
9. dmitry-shibanov

   closed this as completedin #694on Oct 10, 2023
10. dmitry-shibanov commented on Oct 10, 2023

    

    dmitry-shibanov

    on Oct 10, 2023

    Contributor

    More actions

    Hello @timfel. We've merged the pull request. Could you please try to use actions/setup-python@main and confirm that it works as expected for you. For now I'm going to reopen the issue until the new version of action is released.
11. dmitry-shibanov

    reopened this on Oct 10, 2023
12. timfel commented on Oct 11, 2023

    

    timfel

    on Oct 11, 2023

    ContributorAuthor

    More actions

    Thanks @dmitry-shibanov. I tried it and it it works as expected
13. kurtmckee commented on Dec 11, 2023

    

    kurtmckee

    on Dec 11, 2023

    Contributor

    More actions

    I tested this using the following configuration:

    - uses: "actions/setup-python@v5"
      with:
        python-version: |
          graalpy-23.1
          pypy-3.10
          3.11

    Link to run, which failed on Windows

    For Linux and macOS, graalpy-23.1 resolved to version 23.1.1.

    However, on Windows, setup-python reported that no "23.1" version existed:

    Run actions/setup-python@v5
      with:
        python-version: graalpy-23.1
      pypy-3.10
      3.11
      
        check-latest: false
        token: ***
        update-environment: true
        allow-prereleases: false
    Installed versions
      GraalPy version 23.1 was not found in the local cache
      Error: GraalPy version 23.1 with arch x64 not found
    

    This is the complete list of files for the GraalPy 23.1.1 release at the time of writing:

    graalpy-23.1.1-linux-aarch64.tar.gz
    graalpy-23.1.1-linux-aarch64.tar.gz.sha256
    graalpy-23.1.1-linux-amd64.tar.gz
    graalpy-23.1.1-linux-amd64.tar.gz.sha256
    graalpy-23.1.1-macos-aarch64.tar.gz
    graalpy-23.1.1-macos-aarch64.tar.gz.sha256
    graalpy-23.1.1-macos-amd64.tar.gz
    graalpy-23.1.1-macos-amd64.tar.gz.sha256
    graalpy-23.1.1-windows-amd64.zip
    graalpy-23.1.1-windows-amd64.zip.sha256
    graalpy-community-23.1.1-linux-aarch64.tar.gz
    graalpy-community-23.1.1-linux-aarch64.tar.gz.sha256
    graalpy-community-23.1.1-linux-amd64.tar.gz
    graalpy-community-23.1.1-linux-amd64.tar.gz.sha256
    graalpy-community-23.1.1-macos-aarch64.tar.gz
    graalpy-community-23.1.1-macos-aarch64.tar.gz.sha256
    graalpy-community-23.1.1-macos-amd64.tar.gz
    graalpy-community-23.1.1-macos-amd64.tar.gz.sha256
    graalpy-community-jvm-23.1.1-linux-aarch64.tar.gz
    graalpy-community-jvm-23.1.1-linux-aarch64.tar.gz.sha256
    graalpy-community-jvm-23.1.1-linux-amd64.tar.gz
    graalpy-community-jvm-23.1.1-linux-amd64.tar.gz.sha256
    graalpy-community-jvm-23.1.1-macos-aarch64.tar.gz
    graalpy-community-jvm-23.1.1-macos-aarch64.tar.gz.sha256
    graalpy-community-jvm-23.1.1-macos-amd64.tar.gz
    graalpy-community-jvm-23.1.1-macos-amd64.tar.gz.sha256
    graalpy-jvm-23.1.1-linux-aarch64.tar.gz
    graalpy-jvm-23.1.1-linux-aarch64.tar.gz.sha256
    graalpy-jvm-23.1.1-linux-amd64.tar.gz
    graalpy-jvm-23.1.1-linux-amd64.tar.gz.sha256
    graalpy-jvm-23.1.1-macos-aarch64.tar.gz
    graalpy-jvm-23.1.1-macos-aarch64.tar.gz.sha256
    graalpy-jvm-23.1.1-macos-amd64.tar.gz
    graalpy-jvm-23.1.1-macos-amd64.tar.gz.sha256
    graalpy-jvm-23.1.1-windows-amd64.zip
    graalpy-jvm-23.1.1-windows-amd64.zip.sha256
    

    It appears that there is an x64-compatible Windows release available, and I expected this to result in GraalPy getting installed for Windows.

    Is this perhaps an issue with Windows releases using .zip as their file extension?
14. timfel commented on Dec 11, 2023

    

    timfel

    on Dec 11, 2023

    ContributorAuthor

    More actions

    @kurtmckee The windows support of graalpy 23.1 is highly experimental, so we excluded it on purpose. The 24 release due out April 24 will improve the situation at which point we'll update the action
15. kurtmckee commented on Dec 11, 2023

    

    kurtmckee

    on Dec 11, 2023

    Contributor

    More actions

    Okay, thanks for the quick response!
16. dmitry-shibanov commented on Dec 25, 2023

    

    dmitry-shibanov

    on Dec 25, 2023

    Contributor

    More actions

    Hello everyone. For now I'm going to close the issue because the support for GraalPy was released in 4.8.0.
17. dmitry-shibanov

    closed this as completedon Dec 25, 2023

Issue actions