GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "Enhance cache-dependency-path handling to support files outside the workspace root" by v-aparnajyothi-y · Pull Request #1186 · actions/setup-python

Conversation

@v-aparnajyothi-y

@v-aparnajyothi-y v-aparnajyothi-y commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

This reverts commit 1264885.

Description:
Reverts PR #1128. That change copied a file from the composite action into the workspace to support composite actions, but we’ve decided to implement this capability at the actions/toolkit level instead (see actions/toolkit#1035) for a more consistent and scalable solution.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@v-HarithaVattikuti
Revert "Enhance cache-dependency-path handling to support files outsi…
e45f974
…de the w…"

This reverts commit 1264885.
Copilot AI review requested due to automatic review settings August 26, 2025 06:33
@v-aparnajyothi-y
v-aparnajyothi-y requested a review from a team as a code owner August 26, 2025 06:33
Copilot AI reviewed Aug 26, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts commit 1264885 which enhanced cache-dependency-path handling to support files outside the workspace. The functionality is being reimplemented at the actions/toolkit level for better consistency across actions.

Key changes:

  • Removes complex file copying logic from the cacheDependencies function
  • Eliminates associated test coverage for the removed functionality
  • Removes documentation note about support for files outside workspace

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/setup-python.ts Reverts cacheDependencies function to simpler implementation without file copying logic
docs/advanced-usage.md Removes documentation note about cache-dependency-path supporting files outside workspace
tests/setup-python.test.ts Removes all test cases for the reverted file copying functionality
.github/workflows/test-pypy.yml Adds windows-2019 to test matrix (unrelated change)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/setup-python.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@v-aparnajyothi-y v-aparnajyothi-y changed the title Revert "Enhance cache-dependency-path handling to support files outsi… Revert "Enhance cache-dependency-path handling to support files outside the workspace root" Aug 26, 2025
v-priya-kinthali
v-priya-kinthali previously approved these changes Aug 26, 2025
View reviewed changes
v-priyagupta108
v-priyagupta108 previously approved these changes Aug 26, 2025
View reviewed changes
Aparna Jyothi
pckage.json version update
558ecb0
@v-aparnajyothi-y
v-aparnajyothi-y dismissed stale reviews from v-priyagupta108 and v-priya-kinthali via 558ecb0 August 26, 2025 13:42
v-priya-kinthali
v-priya-kinthali approved these changes Aug 26, 2025
View reviewed changes
v-priyagupta108
v-priyagupta108 approved these changes Aug 26, 2025
View reviewed changes
v-HarithaVattikuti
v-HarithaVattikuti approved these changes Aug 28, 2025
View reviewed changes
@v-HarithaVattikuti
v-HarithaVattikuti merged commit 3d1e2d2 into main Aug 28, 2025
@v-HarithaVattikuti
v-HarithaVattikuti deleted the revert-1128-enhance-cache-dependency-path branch August 28, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@v-HarithaVattikuti v-HarithaVattikuti v-HarithaVattikuti approved these changes
@v-priya-kinthali v-priya-kinthali v-priya-kinthali approved these changes
@v-priyagupta108 v-priyagupta108 v-priyagupta108 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@v-aparnajyothi-y @v-HarithaVattikuti @v-priya-kinthali @v-priyagupta108
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.