GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — Add support for adding a token on GHES to prevent rate limiting by HenrikPoulsen · Pull Request #316 · actions/setup-python ConversationDescription: No idea if this change is idiomatic or not since I don't usually work with typescript. Related issue: Check list:
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
HenrikPoulsen
force-pushed
the
ghes-token
branch
from
9d1a2cb to
248abfd
Compare
HenrikPoulsen
force-pushed
the
ghes-token
branch
from
248abfd to
06ce3b6
Compare
brcrista
suggested changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We've discussed different approaches to this problem. This approach should work, but requiring users to create a PAT in github.com to then use in GHES would create more problems than it would solve. I think the best approach to unblock you is to fork the action on your GHES instance and apply these changes.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
The solution implemented in this PR will continue to work exactly as today, for users not setting up til github.com PAT in their GHE project. It will work until they hit a rate limit. This PR provides a solution to that, for those interested. Isn't that to prefer, compared to not have a solution? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It doesn't seem like a common issue so far, but we have thought about it. Having to add a GHES-specific input to an action suggests to me that there's a smoother flow we should look for on the backend. The solution we would like to implement is to make this flow part of GitHub Connect. That would solve the problem in a general way for all first-party actions and be consistent with other flows that fit this pattern. No ETA on this, though. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hello @brcrista |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Vercasek1985 I recommend forking the action to unblock yourself. As I said above, passing a PAT is a quick fix but not something that we want to support long-term. @HenrikPoulsen I'm going to close this PR since we're not planning on merging it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.