GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add support for adding a token on GHES to prevent rate limiting by HenrikPoulsen · Pull Request #316 · actions/setup-python

Conversation

@HenrikPoulsen

@HenrikPoulsen HenrikPoulsen commented Jan 10, 2022

Copy link
Copy Markdown

Description:
Adding a new input to specify a token when running on GHES.
When running on GHES today token gets thrown away even when explicitly set to be a github.com token.
So there is no good way to avoid the rate limiting that would occur.

No idea if this change is idiomatic or not since I don't usually work with typescript.
So let me know if there's any changes you would want me to make.

Related issue:
#229

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lasse-aagren, opdude, egmar, gshel, and sonikro reacted with thumbs up emoji
All reactions
  • 👍 5 reactions
@HenrikPoulsen
Add support for adding a token on GHES to prevent rate limiting
0b992d8
@HenrikPoulsen
HenrikPoulsen force-pushed the ghes-token branch from 9d1a2cb to 248abfd Compare January 11, 2022 13:42
@HenrikPoulsen
Return undefined if GHES_TOKEN is not set when running on GHES
06ce3b6
@HenrikPoulsen
HenrikPoulsen force-pushed the ghes-token branch from 248abfd to 06ce3b6 Compare January 11, 2022 13:42
brcrista
brcrista suggested changes Jan 21, 2022
View reviewed changes

@brcrista brcrista left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've discussed different approaches to this problem. This approach should work, but requiring users to create a PAT in github.com to then use in GHES would create more problems than it would solve.

I think the best approach to unblock you is to fork the action on your GHES instance and apply these changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@HenrikPoulsen

HenrikPoulsen commented Jan 21, 2022

Copy link
Copy Markdown
Author

What about fixing this for everyone that isn't me then?
Will something be done to fix this rate limiting issue? This PR at least proposes a generic workaround. Is it a hassle to set up? Sure
Does it solve a problem for people who are straight up blocked? Yes
Just making sure this isn't the end of the road for fixing this issue permanently

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lasse-aagren

lasse-aagren commented Jan 24, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The solution implemented in this PR will continue to work exactly as today, for users not setting up til github.com PAT in their GHE project.

It will work until they hit a rate limit.

This PR provides a solution to that, for those interested. Isn't that to prefer, compared to not have a solution?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brcrista

brcrista commented Jan 24, 2022

Copy link
Copy Markdown
Contributor

It doesn't seem like a common issue so far, but we have thought about it.

Having to add a GHES-specific input to an action suggests to me that there's a smoother flow we should look for on the backend. The solution we would like to implement is to make this flow part of GitHub Connect. That would solve the problem in a general way for all first-party actions and be consistent with other flows that fit this pattern. No ETA on this, though.

HenrikPoulsen and austinsasko reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Vercasek1985

Vercasek1985 commented Jun 1, 2022

Copy link
Copy Markdown

Hello @brcrista
I am working in the automation team. We do the automation in ansible. Github is used heavily in our company (Kyndryl) and we really need this fix ASAP. Could you please help me, what can we do to prioritize this issue to be fixed in very near future?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brcrista

brcrista commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

@Vercasek1985 I recommend forking the action to unblock yourself. As I said above, passing a PAT is a quick fix but not something that we want to support long-term.

@HenrikPoulsen I'm going to close this PR since we're not planning on merging it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brcrista brcrista closed this Jun 2, 2022
@retzero retzero mentioned this pull request Jul 15, 2022
Support get manifest from local #463
Closed
@C1ARKGABLE C1ARKGABLE mentioned this pull request Aug 23, 2023
Add support for locally hosted GHES instances to reduce rate limiting #720
Closed
1 of 2 tasks
@Shegox Shegox mentioned this pull request Oct 31, 2023
Enhance setup-python Action in GitHub Enterprise Server with Raw API Fallback Mechanism #756
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@brcrista brcrista brcrista requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@HenrikPoulsen @lasse-aagren @brcrista @Vercasek1985
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.