GeezerVison is showing github.com — feat: bump to use node20 runtime, actions/checkout to v4 by kbdharun · Pull Request #727 · actions/setup-python
Conversation
kbdharun
commented
Sep 5, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Description:
Node20 was added to Actions Runner on v2.308.0 and Node16 reaches end of life soon on 11 Sep 2023.
Therefore, This PR updates the default runtime to node20. I have bumped the actions/checkout version to v4 for the same.
Related issue:
actions/runner#2732
Check list:
- Mark if documentation changes are required.
- Mark if tests were added or updated to cover the changes.
A major version bump might be needed after the PRs merge.
I referred to actions/setup-go#421 for this PR.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
aoirint reacted with heart emoji
kbdharun
changed the title
feat: bump to use node20 runtime
feat: bump to use node20 runtime, actions/checkout to v4
Sep 5, 2023
|
Hello @kbdharun. Thank you for your pull request. Could you please revert changes in docs/adrs/0000-caching-dependencies.md
|
kbdharun reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Oct 26, 2023
|
what is blocking the PR merge?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
This was superseded by #772.
|
kbdharun reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was superseded by #772.
Thanks for the information 😄 , glad it got merged.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
2 more reviewers
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.