GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: bump to use node20 runtime, actions/checkout to v4 by kbdharun · Pull Request #727 · actions/setup-python

Conversation

@kbdharun

@kbdharun kbdharun commented Sep 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Description:

Node20 was added to Actions Runner on v2.308.0 and Node16 reaches end of life soon on 11 Sep 2023.

Therefore, This PR updates the default runtime to node20. I have bumped the actions/checkout version to v4 for the same.

Related issue:

actions/runner#2732

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

A major version bump might be needed after the PRs merge.
I referred to actions/setup-go#421 for this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aoirint reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@kbdharun
feat: bump to use node20 runtime
8c9958e
@kbdharun
kbdharun requested a review from a team as a code owner September 5, 2023 03:28
@kbdharun
CI: bump actions/checkout version to v4
7260016
@kbdharun kbdharun changed the title feat: bump to use node20 runtime feat: bump to use node20 runtime, actions/checkout to v4 Sep 5, 2023
@dmitry-shibanov

dmitry-shibanov commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Hello @kbdharun. Thank you for your pull request. Could you please revert changes in docs/adrs/0000-caching-dependencies.md

kbdharun reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kbdharun
Revert changes to docs/adrs/0000-caching-dependencies.md
d89776d
@takana-v takana-v mentioned this pull request Sep 18, 2023
actionsをアップデートする VOICEVOX/voicevox_engine#748
Merged
IvanZosimov
IvanZosimov approved these changes Sep 29, 2023
View reviewed changes
This was referenced Oct 26, 2023
Upgrade to node20 #752
Closed
Upgrade checkout action #754
Closed
@kurtmckee kurtmckee mentioned this pull request Oct 31, 2023
Readme refers to old version of actions/checkout #755
Closed
chenrui333
chenrui333 approved these changes Oct 31, 2023
View reviewed changes
@chenrui333

chenrui333 commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

what is blocking the PR merge?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@akx

akx commented Dec 12, 2023

Copy link
Copy Markdown
Contributor

This was superseded by #772.

kbdharun reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kbdharun

kbdharun commented Dec 12, 2023

Copy link
Copy Markdown
Author

This was superseded by #772.

Thanks for the information 😄 , glad it got merged.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kbdharun kbdharun closed this Dec 12, 2023
@kbdharun
kbdharun deleted the patch-1 branch December 12, 2023 13:48
@coderabbitai coderabbitai Bot mentioned this pull request Aug 21, 2026
⚡ Bolt: optimize GitHub Actions execution by upgrading core actions to Node 20 compatible versions spyro2646/pos-addons#122
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@chenrui333 chenrui333 chenrui333 approved these changes
@IvanZosimov IvanZosimov IvanZosimov approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@kbdharun @dmitry-shibanov @chenrui333 @akx @IvanZosimov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.