GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — perf: add dynamically loaded cache-dependencies module by aminya · Pull Request #728 · actions/setup-python

Conversation

@aminya

@aminya aminya commented Sep 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Description:
This reduces the main bundle size by ⚠️ 1.28 MB minified! This bundle is loaded only when caching is enabled.

setup-python is used in setup-cpp as a library. This optimization reduces the bundle size for that package as well. The build system of setup-python uses ncc, which doesn't immediately benefit from this change, but setup-cpp uses Parcel, which shows this huge improvement.

The reason for this huge reduction is that caching the dependencies uses the @actions/cache package, which is an extremely large package with big dependencies. The bundle size before this separation shows this:
Screenshot_20230907_230625

Related issue:

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aminya
aminya requested a review from a team as a code owner September 8, 2023 06:05
@aminya aminya mentioned this pull request Sep 8, 2023
perf: add dynamically loaded cache-dependencies for actions python aminya/setup-cpp#199
Merged
@aminya
aminya force-pushed the cache-bundle-size branch from a783db6 to 5958a00 Compare September 11, 2023 08:28
@aminya
aminya force-pushed the cache-bundle-size branch from 5958a00 to 63858ce Compare September 20, 2024 22:34
@aminya
perf: add dynamically loaded cache-dependencies module
9700887 
This reduces the main bundle size by ⚠️  1.1 MB minified! This bundle is loaded only when caching is enabled.

The reason for this huge reduction is that caching dependencies uses the `@actions/cache` package, which is an extremely large package with big dependencies.

`setup-python` is used in `setup-cpp` as a library. This optimization reduces the bundle size for that package as well.
@aminya
aminya force-pushed the cache-bundle-size branch from 63858ce to 9700887 Compare September 20, 2024 22:36
@aminya

aminya commented Sep 20, 2024

Copy link
Copy Markdown
Author

@konradpabjan could you review this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@aminya
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.