GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [PoC] Tailwind v4 css configuration by mgrunberg · Pull Request #8649 · activeadmin/activeadmin

Conversation

@mgrunberg

@mgrunberg mgrunberg commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

Built on top of #8640

Exploring an idea to move from javascript config to CSS config.

Pros: Use the latest tailwind configuration mechanism (clean IMO).
Cons: There won't be a single way to configure tailwind.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
mgrunberg added 16 commits February 26, 2025 13:57
@mgrunberg
bump tailwind from 3.4.17 to 4.0.9 & flowbite from 2.3.0 to 3.1.2
38a62d7
@mgrunberg
remove tailwind v3 downgrade from test-application
d303407
@mgrunberg
use tailwind cli to compile css
c0808fd
@mgrunberg
delete generated files that are not used
a4165cd
@mgrunberg
Update flowbite code
7c72150
@mgrunberg
add a reference to old javascript config file
367b427
@mgrunberg
remove @tailwind directive
9964aa4
@mgrunberg
remove config argument when adding build:css script to test app
187fe37
@mgrunberg
rename deprecated utility
d3879a5
@mgrunberg
update renamed utitiles
c7620f8
https://tailwindcss.com/docs/upgrade-guide#renamed-utilities
@mgrunberg
make sure that our configuration is an ES module
3bfb95e
@mgrunberg
Revert "make sure that our configuration is an ES module"
2eac194
This reverts commit 3bfb95e.
@mgrunberg
remove fixme
d89ac9f
@mgrunberg
Merge branch 'master' into tailwind-v4
92413c5
@mgrunberg
use css configuration for tailwind
34227e3
@mgrunberg
temporal: hardcode replacement for test/development environment
01ed5ba
@codecov

codecov Bot commented Mar 5, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (542f7d6) to head (01ed5ba).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8649   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4073     4073           
=======================================
  Hits         4037     4037           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hasghari

hasghari commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

@mgrunberg Would the configuration be simplified if the view files were published in the NPM package, similar to what #8220 was trying to achieve? I think that would remove the need for the #ACTIVE_ADMIN_GEM# placeholder in the config and allow for referencing the plugin and view files using a relative path.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mgrunberg

mgrunberg commented Mar 26, 2025

Copy link
Copy Markdown
Contributor Author

@mgrunberg Would the configuration be simplified if the view files were published in the NPM package, similar to what #8220 was trying to achieve? I think that would remove the need for the #ACTIVE_ADMIN_GEM# placeholder in the config and allow for referencing the plugin and view files using a relative path.

@hasghari Thanks for the contribution, but I'm not ready to reopen the #8220 discussion. That's why I'm still referencing gem files.

Speaking about simplicity, I do have the idea of reducing the usage of #ACTIVE_ADMIN_GEM, but I'm not finding time to come back to the PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sbounmy sbounmy mentioned this pull request Apr 2, 2025
100 poc chagpt 4o image gen sbounmy/hongbao_bitcoin#101
Merged
@amkisko

amkisko commented Apr 30, 2025

Copy link
Copy Markdown

Hey!

I've successfully moved to tailwind v4 by having both javascript and css configurations within the same setup. Full configuration is here: https://gist.github.com/amkisko/af1b2f7dc4f0f941437ea16400277864

The idea is to use "old" way with custom rake task and javascript configuration file for resolving dynamic paths in pair with @config "../../../config/tailwind-active_admin.config.js"; tailwind v4 config method. ActiveAdmin tailwind plugin does not work, so it requires rewriting to the new v4 syntax fully.

tagliala, setoelkahfi, and javierartero reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tagliala tagliala changed the title Tailwind v4 css configuration [PoC] Tailwind v4 css configuration Dec 20, 2025

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mgrunberg @hasghari @amkisko
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.