GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — non-DMA SPI working; adding this now for testing; will continue with DMA by dhalbert · Pull Request #443 · adafruit/circuitpython

Conversation

@dhalbert

@dhalbert dhalbert commented Nov 16, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Tested with BMP280 SPI on '21 and '51

needs corresponding ASF4 PR as well

Also, fixed pin mappings for rev B Metro M4:
swap PA12 and PA13 on SPI 2x3 header
swap A3 and A5

Comment out all frozen modules in CPX again to make room while waiting
for SPI flash.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dhalbert
dhalbert requested a review from tannewt November 16, 2017 22:16
tannewt
tannewt requested changes Nov 16, 2017
View reviewed changes

@tannewt tannewt left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! One minor thing plus you'll need to update the asf4 module to the real commit now that its pulled.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread ports/atmel-samd/common-hal/busio/SPI.c Outdated

@tannewt tannewt Nov 16, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has two _peripherals.h files. Did you mean to merge them?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@dhalbert dhalbert Nov 17, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - peripherals.h includes either samd21_peripherals.h or samd51_peripherals.h. They are slightly different. Is that what you mean?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@tannewt tannewt Nov 17, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see peripherals.h in the diff.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@dhalbert dhalbert Nov 17, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it in the previous PR when I did I2C. It hasn't changed: it's just conditional #includes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tannewt

tannewt commented Nov 17, 2017

Copy link
Copy Markdown
Member

Ah ok! You'll need to fix the build because CircuitPlayground is out of space.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tannewt
tannewt previously approved these changes Nov 17, 2017
View reviewed changes
@dhalbert
non-DMA SPI working; adding this now for testing; will continue with DMA
312444b 
Also, fixed pin mappings for rev B Metro M4:
swap PA12 and PA13 on SPI 2x3 header
swap A3 and A5

Comment out all frozen modules in CPX again to make room while waiting
for SPI flash.
@dhalbert
dhalbert dismissed tannewt’s stale review via 312444b November 17, 2017 00:11
@dhalbert
dhalbert force-pushed the 3.0_spi branch from 7a03806 to 312444b Compare November 17, 2017 00:11
@dhalbert
dhalbert merged commit a9f75a7 into adafruit:master Nov 17, 2017
@dhalbert
dhalbert deleted the 3.0_spi branch November 17, 2017 03:24
@dhalbert dhalbert mentioned this pull request Nov 29, 2017
Add busio support to atmel-samd. #259
Closed
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tannewt tannewt tannewt left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dhalbert @tannewt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.