GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix save retry mechanism by eggplants · Pull Request #124 · akamhy/waybackpy

Conversation

@eggplants

@eggplants eggplants commented Feb 3, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

WaybackMachineSaveAPI.save raises AttributeError: 'WaybackMachineSaveAPI' object has no attribute 'response_url' when max_tries < 1.

$ pip show waybackpy
Name: waybackpy
Version: 3.0.2
Summary: Python package that interfaces with the Internet Archive's Wayback Machine APIs. Archive pages and retrieve archived pages easily.
Home-page: https://akamhy.github.io/waybackpy/
Author: Akash Mahanty
Author-email: [email protected]
License: MIT
Location: /Users/eggplants/.pyenv/versions/3.9.9/lib/python3.9/site-packages
Requires: click, requests
Required-by: wbsv
$ python -c 'import waybackpy;waybackpy.WaybackMachineSaveAPI("https://google.co.jp", max_tries=0).save()'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/eggplants/.pyenv/versions/3.9.9/lib/python3.9/site-packages/waybackpy/save_api.py", line 170, in save
    % (self.url, self.response_url, str(self.headers)),
AttributeError: 'WaybackMachineSaveAPI' object has no attribute 'response_url'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@eggplants
fix: save retry mechanism
bc1dc4d
@akamhy
akamhy merged commit 947647f into akamhy:master Feb 3, 2022
@eggplants
eggplants deleted the fix_save_retry branch February 3, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@eggplants @akamhy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.