GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add sort, use_pagination and closest by akamhy · Pull Request #158 · akamhy/waybackpy

Conversation

@akamhy

@akamhy akamhy commented Feb 17, 2022

Copy link
Copy Markdown
Owner

closes #157

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
akamhy added 7 commits February 17, 2022 12:08
@akamhy
add sort param support in CDX API class
b4adf4a 
see https://nla.github.io/outbackcdx/api.html#operation/query

sort takes string input which must be one of the follwoing:
- default
- closest
- reverse

This commit shall help in closing issue at #155
@akamhy
add BlockedSiteError for cases when archiving is blocked by site's ro…
faa97e5 
…bots.txt
@akamhy
create check_for_blocked_site for handling the BlockedSiteError for s…
28f4b57 
…ites that are blocking wayback machine by their robots.txt policy
@akamhy
add attrs use_pagination and closest, which are can be used to use th…
0e7255c 
…e pagination API and lookup archive close to a timestamp respectively. And now to get out of infinte blank pages loop just check for two succesive black and not total two blank pages while using the CDX server API.
@akamhy
added cli support for sort, use-pagination and closest
b541d8d
@akamhy
added tests
6cd9ae1
@akamhy
fix codeql warnings, nothing to worry about here.
4486123
@pep8speaks

pep8speaks commented Feb 17, 2022

Copy link
Copy Markdown

Hello @akamhy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

  • In the file waybackpy/cdx_utils.py:

Line 54:9: W503 line break before binary operator
Line 55:9: W503 line break before binary operator

  • In the file waybackpy/cli.py:

Line 281:5: W503 line break before binary operator
Line 303:5: W503 line break before binary operator
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@akamhy akamhy added the enhancement New feature or request label Feb 17, 2022
@akamhy
fix save test for archive_url
e94da0c
@codecov

codecov Bot commented Feb 17, 2022

Copy link
Copy Markdown

Codecov Report

Merging #158 (e94da0c) into master (f63c6ad) will increase coverage by 1.21%.
The diff coverage is 88.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   94.24%   95.45%   +1.21%     
==========================================
  Files          10       10              
  Lines         608      638      +30     
==========================================
+ Hits          573      609      +36     
+ Misses         35       29       -6
Impacted Files Coverage Δ
waybackpy/cdx_api.py 92.59% <82.35%> (+2.39%) ⬆️
waybackpy/cdx_utils.py 96.29% <88.88%> (-2.15%) ⬇️
waybackpy/cli.py 95.29% <100.00%> (+0.17%) ⬆️
waybackpy/exceptions.py 100.00% <100.00%> (ø)
waybackpy/wrapper.py 92.53% <0.00%> (+8.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f63c6ad...e94da0c. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@akamhy
akamhy merged commit f990b93 into master Feb 17, 2022
@akamhy
akamhy deleted the add-sort-in-cdx branch February 17, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CDX API handling of excluded from the Wayback Machine URLs

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@akamhy @pep8speaks
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.