GeezerVison is showing github.com — Adjust code to Eigen 5.0.0 by eddelbuettel · Pull Request #3 · alenxav/bWGR
Conversation
Eigen 5.0.0, which we are trying to bring to CRAN in an updated RcppEigen, did away with Eigen::all (and Eigen::MappedSparseMatrix), see the release notes (fourth bullet point under breaking changes for 'all'). (Also note that they changed the versioning scheme so Eigen 5.0.0 corresponds to 3.5.0 under the old scheme.) See RcppEigen issue 151 for all the changes related to this upgrade.
For Eigen::all, it appears that the preceding Eigen 3.4.0 introduced Eigen::indexing::all (see its release notes) and that is still available in 5.0.0 too. So this PR replaces one Eigen::all with Eigen::indexing::all. We verified that this passes with both the current RcppEigen on CRAN, and the release candidate in our master branch. For MappedSparseMatrix, a change to Map works. No other changes are made in the PR.
So if you could apply this PR and get the update to CRAN before we update, a new RcppEigen would not break your package. If you don't update it we would get breakage 😞 but this PR overcomes this. We have been at this update for a long time as there were other issues in affected packages so the upload is not really imminent -- but getting closer. If you can get this to CRAN over the next few weeks we would appreciate it.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
There is a large amount of whitespace-only changes here, try adding ?w=1 to the URL as in 4ff87e4?w=1 to condense. I could convert the two C++ files to windows lineends if you prefer to minimise the changes.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
The plan is to ship the updated RcppEigen to CRAN in mid-to-late November. If your package is up-to-date at CRAN by then, no worries. If it is not, we can expect the CRAN maintainers to reach out and place some firmer deadlines on your package is it will likely break unless updated with this PR (or equivalent changes).
If there is anything I can do to assist you in making the update, please do not hesitate to let me know either here, at the RcppEigen repo, or by email.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.