GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [ALERT] Fix for breaking changes introduced by Bearer Token work by zeryx · Pull Request #121 · algorithmiaio/algorithmia-python

Conversation

@zeryx

@zeryx zeryx commented Dec 22, 2021

Copy link
Copy Markdown
Contributor

the PR #116 introduced the concept of bearer tokens; but did not provide a mechanism for gracefully failing in the event that no API key is provided; this fix ensures that the bearer token is optional, and only attempted if a bearer token is provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zeryx
critical fix to bearer token breakage
418d45a
@zeryx zeryx added the bug label Dec 22, 2021
@zeryx
zeryx requested a review from John-Bragg December 22, 2021 19:20
@zeryx zeryx self-assigned this Dec 22, 2021
@zeryx
corrected issue with header initialization in json helper
6e01553
@zeryx
zeryx requested review from aslisabanci and kennydaniel December 22, 2021 19:33
aslisabanci
aslisabanci previously approved these changes Dec 22, 2021
View reviewed changes
@zeryx
removed else exception, no auth is passed by internal algo API proces…
47ec255 
…sing
@zeryx
zeryx dismissed aslisabanci’s stale review via 47ec255 December 22, 2021 19:43
platypii
platypii previously approved these changes Dec 22, 2021
View reviewed changes
@zeryx
added a test case tracking authorization required server responses an…
536ed0c 
…d system handling no auth provided gracefully
@zeryx
zeryx dismissed platypii’s stale review via 536ed0c December 22, 2021 20:07
@zeryx
added a false flag to actually invalidate environment variables for c…
c749878 
…lient auth
aslisabanci
aslisabanci previously approved these changes Dec 22, 2021
View reviewed changes
Comment thread Algorithmia/client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@zeryx
cleaned up client, used environment variable manipulation in the test…
3c66afc 
… suite
@zeryx
zeryx dismissed aslisabanci’s stale review via 3c66afc December 22, 2021 21:16
@zeryx
removing problematic server test
e593dbf
@zeryx
zeryx requested a review from aslisabanci December 22, 2021 21:32
aslisabanci
aslisabanci approved these changes Dec 22, 2021
View reviewed changes
@zeryx
zeryx merged commit 7fd688d into develop Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@John-Bragg John-Bragg Awaiting requested review from John-Bragg
@kennydaniel kennydaniel Awaiting requested review from kennydaniel
2 more reviewers
@aslisabanci aslisabanci aslisabanci approved these changes
@platypii platypii platypii left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zeryx zeryx

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@zeryx @platypii @aslisabanci
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.