GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow configurable page source in AllureSelenide by yaroslav-orel · Pull Request #394 · allure-framework/allure-java

Conversation

@yaroslav-orel

@yaroslav-orel yaroslav-orel commented Sep 18, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Context

I need to be able to configure page source for attachments in AllureSelenide. I use appium for automation of native mobile applications. On getPageSource() request Appium returns XML tree by default (and it can also be configured to return JSON), not HTML like Selenium WebDriver. So when my XML is treated as HTML, attachment is not displayed in Allure. It's just blank (because of source type mismatch).
So my pull request fixes this issue. By default HTML source type is implied but client can configure it to their needs using configureSource() method.

Checklist

  • Sign Allure CLA
  • Provide unit tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@CLAassistant

CLAassistant commented Sep 18, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@yaroslav-orel
yaroslav-orel force-pushed the config-page-source branch from 803db1f to df89f35 Compare September 18, 2019 12:08
@yaroslav-orel
Allow configurable page source
c5d9c55
@yaroslav-orel
yaroslav-orel force-pushed the config-page-source branch from df89f35 to c5d9c55 Compare September 18, 2019 12:16
@yaroslav-orel
Fix checkstyle issue
da91fe4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@yaroslav-orel @CLAassistant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.