GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Set the correct detail message for passed steps (fix #835) by sharovd · Pull Request #853 · allure-framework/allure-python

Conversation

@sharovd

@sharovd sharovd commented Apr 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Context

  • Fix the issue allure_robotframework sets incorrect statusDetails message for steps #835
  • It's necessary to clear self._current_tb and self._current_msg fields in _report_messages() method in case if step is passed, otherwise the wrong detail message saved for failed step will be used in the report.
  • Here is an example of reports (by robot and allure) after the fix:
Report Robot Report Allure

Checklist

  • Sign Allure CLA
  • Provide unit tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sharovd
fix: set the correct detail message for passed steps (allure-framewor…
e8d845e 
…k#835)
@delatrie delatrie self-assigned this Apr 8, 2025
@delatrie delatrie added type:enhancement theme:robotframework labels Apr 8, 2025
delatrie
delatrie requested changes Apr 21, 2025
View reviewed changes

@delatrie delatrie left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @sharovd ! Thank you very much for contributing to allure-python.

I've checked the changes, and the code looks good to me. The only missing thing is a test that reproduces the issue. Could you pls add one?

If you need some guidance on how to test allure-robotframework, please let me know, and I will gladly help you.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@delatrie delatrie linked an issue Apr 21, 2025 that may be closed by this pull request
allure_robotframework sets incorrect statusDetails message for steps #835
Closed
@sharovd
test: add covering issue allure-framework#835
c00ae44
@sharovd

sharovd commented Apr 24, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Hi, @delatrie! Thanks for the review!
I've added the test test_only_failed_steps_have_status_details() that reproduces the problem described. I have verified that it fails on the master branch and passes with my changes.
The test follows the structure of the existing ones in the repository, but if you spot anything that could be improved, feel free to tell me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
delatrie
delatrie approved these changes Apr 24, 2025
View reviewed changes

@delatrie delatrie left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sharovd reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@delatrie
delatrie merged commit 68bbafe into allure-framework:master Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delatrie delatrie delatrie approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@delatrie delatrie

Labels

theme:robotframework type:enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allure_robotframework sets incorrect statusDetails message for steps

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sharovd @delatrie
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.