GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(behave): add cleanup; fix invalid call from AllureHooks by delatrie · Pull Request #860 · allure-framework/allure-python

Conversation

@delatrie

@delatrie delatrie commented May 5, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Context

At the beginning of the test run, Allure Behave registers a file logger that writes test results on disk. Due to a lack of cleanup, when Behave is run in-process, those loggers keep accumulating, which increases the number of written files exponentially.

The PR adds the cleanup for the AllureFormatter and AllureHooks, which fixes the issue.

Extra changes

  • fix invalid function call in AllureHooks.before_feature: it should call AllureListener.start_file, not AllureListener.start_feature

Fixes #629
Fixes #858

Checklist

  • Sign Allure CLA
  • Provide unit tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brolnickij, rnairrajeev, and MadhurSharma033 reacted with heart emoji
All reactions
  • ❤️ 3 reactions
delatrie added 4 commits May 6, 2025 00:50
@delatrie
test(behave): fix runner not to break behave.__main__
3d42945
@delatrie
test(behave): add test to reproduce #858
e293b8a
@delatrie
fix(behave): invalid function called by AllureHooks.before_feature
4422ef8 
Fixes #629
@delatrie
fix(behave): add proper cleanup
3a59d6e
@delatrie delatrie added theme:behave type:bug Pull requests that fix bugs labels May 5, 2025
@delatrie delatrie mentioned this pull request May 5, 2025
Exponential Growth in Allure Results with Each Iteration in runner.py Script #858
Closed
@epszaw epszaw assigned delatrie May 6, 2025
todti
todti approved these changes May 6, 2025
View reviewed changes
epszaw
epszaw approved these changes May 6, 2025
View reviewed changes
@delatrie
delatrie merged commit 3cd731a into master May 6, 2025
@delatrie
delatrie deleted the issue858-fix branch May 6, 2025 11:05
@delatrie delatrie mentioned this pull request May 6, 2025
Do not call not existing start_feature method (fixes #629) #645
Closed
1 of 2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epszaw epszaw epszaw approved these changes
@todti todti todti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@delatrie delatrie

Labels

theme:behave type:bug Pull requests that fix bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exponential Growth in Allure Results with Each Iteration in runner.py Script hooks.py throws exception because of missing listener function

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@delatrie @epszaw @todti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.