GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Migrate to pyproject.toml by nirosys · Pull Request #379 · amazon-ion/ion-python Conversation
|
|
Windows build issue: and I missed the performance regression workflow: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…e updated to do the same for baseline once merged)
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| - run: pip install --upgrade setuptools | ||
| - run: pip install -r requirements.txt | ||
| - run: pip install -e . | ||
| - run: python -m pip install build virtualenv |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Why does this action also install virtualenv but the test-windows does not?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch, ty. I'll remove that, we're not using virtualenv in the workflows.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| specs: '{command:read,format:ion_text} {command:write,format:ion_text} {command:read,format:ion_binary} {command:write,format:ion_binary}' | ||
| test_data_id: 'generated-test-data' | ||
| run_cli: 'python amazon/ionbenchmark/ion_benchmark_cli.py' | ||
| run_cli_new: 'python src-python/amazon/ionbenchmark/ion_benchmark_cli.py' |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Should we just replace run_cli instead of run_cli_new?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The new run_cli_new is temporary, to allow this PR to run the perf regression workflow. Since it pulls down the current HEAD which has the pre-PR layout, I need to run the benchmark CLI from that revision with run_cli.
Once this PR is merged, then I can follow up with a PR to replace run_cli with run_cli_new, so that the perf regression workflow continues working using the src-python layout for everything.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| compile setup import ionc module | ||
|
|
||
| The `amazon.ion.simpleion` module then makes use of this extension when it is available to provide more efficient | ||
| Ion parsing. Importing `amazon._ioncmodule` directly can determine if it is available, however simpleion also provides |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
reading and writing, loading and dumping, not just parsing is all i mean.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| test = [ | ||
| "pytest==8.3.3" | ||
| ] | ||
| benchmarking = [ |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
🙌
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| COMPONENT python_module | ||
| DESTINATION ${PY_BUILD_CMAKE_MODULE_NAME}) | ||
|
|
||
| # install(FILES _ioncmodule.pyi |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
delete?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Ah! Yes, I'll get rid of that and follow up. There is a way to export python stubs for extensions to allow IDEs to present function and type information for an extension's methods. I left that as a reminder, but will follow up with it after this PR.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
That would be neat.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| return exception; | ||
| } | ||
|
|
||
| PyObject *ionc_version() { |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
nice.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…ve commented cmake code
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.