Description

chuckjaz

opened on Dec 18, 2017

Issue body actions

I'm submitting a...

[x] Bug report  

Current behavior

The metadata that is bundled with a FSEM is does not reflect rewritings performed by the compiler.

Expected behavior

The rewritings are taken into account in the metadata.

Minimal reproduction of the problem with instructions

From: https://github.com/dherges/ng-packagr/issues/382

git clone [email protected]:darkbasic/ngx-selectable-list.git
git checkout packagr
npm install
npm run packagr

Note that the new expression the the metadata for SelectableListModule which not present in src/app/selectable-list/directive/selectable-list/selectable-list.directive.metadata.json when compiled with ngc -p ./src/tsconfig.app.json.

What is the motivation / use case for changing the behavior?

The bundled version should apply rewritings.

Activity

1. alxhub

   added

   area: coreIssues related to the framework runtimeIssues related to the framework runtime

   on Dec 19, 2017
2. chuckjaz

   added

   freq2: medium

   severity3: broken

   type: bug/fix

   on Dec 19, 2017
3. ngbot

   added this to the Backlog milestone on Jan 23, 2018
4. dherges commented on Jan 25, 2018

   

   dherges

   on Jan 25, 2018

   Contributor

   More actions

   Here is another issue description:

   In the repro at https://github.com/georgiee/ng-packagr-foos, the bundled metadata json (scoped-some-name.metadata.json) has no metadata for FooModule and FooComponent. But, these two are exported by the FESM bundles ((esm5|esm2015)/scoped-some-name.js).

   Is that the same issue?

   Reacted by Georgios Kaleadis
5. ngbot

   modified the milestones: Backlog, needsTriage on Feb 26, 2018
6. pkozlowski-opensource

   added

   area: compilerIssues related to `ngc`, Angular's template compilerIssues related to `ngc`, Angular's template compiler

   and removed

   area: coreIssues related to the framework runtimeIssues related to the framework runtime

   on Mar 12, 2020
7. alxhub

   added

   engine: ve

   fixed by Ivy

   state: confirmed

   triage #1

   on May 28, 2020
8. alxhub commented on May 28, 2020

   

   alxhub

   on May 28, 2020

   Member

   More actions

   This is a longstanding and well known issue with View Engine's metadata bundler, and is systemic and non-trivial to fix. The good news is that Angular Ivy does not use the metadata system at all, and therefore this bug is rapidly becoming obsolete.
9. jelbourn

   added

   P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentAn issue that is relevant to core functions, but does not impede progress. Important, but not urgent

   P5The team acknowledges the request but does not plan to address it, it remains open for discussionThe team acknowledges the request but does not plan to address it, it remains open for discussion

   and removed

   P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentAn issue that is relevant to core functions, but does not impede progress. Important, but not urgent

   severity3: broken

   on Oct 1, 2020
10. JoostK commented on May 14, 2021

    

    JoostK

    on May 14, 2021

    Member

    More actions

    With v12 now allowing libraries to be compiled with the Ivy compiler, this issue has been resolved.
11. JoostK

    closed this as completedon May 14, 2021
12. angular-automatic-lock-bot commented on Jun 14, 2021

    

    angular-automatic-lock-botBot

    on Jun 14, 2021

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
13. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Jun 14, 2021

Issue actions