Description

shrivatsahosabettu

opened on Feb 12, 2018

Issue body actions

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[x] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

In Architecture Overview --> Angular Libraries
as in the below screen print it says "You also import NgModules from Angular libraries using JavaScript import statements:" which is in contradiction with the example shown in the code

Expected behavior

The description should have been "You also import BroserModul from Angular libraries using JavaScript import statements:" to inline with the code example given

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Angular version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

Activity

1. trotyl commented on Feb 12, 2018

   

   trotyl

   on Feb 12, 2018

   Contributor

   More actions

   Please note the s(plural), BrowserModule is only an example used, your app may import several different others NgModules as well, nothing wrong with that.

   Would you suggest something like:

   You also import NgModules (eg. BrowserModule) from Angular libraries using JavaScript import statements?
2. shrivatsahosabettu commented on Feb 12, 2018

   

   shrivatsahosabettu

   on Feb 12, 2018

   Author

   More actions

   Yes, that would be lot better.. Thanks for your comments.
3. mhevery

   added

   comp: docs

   on Feb 13, 2018
4. jenniferfell commented on Feb 15, 2018

   

   jenniferfell

   on Feb 15, 2018

   Contributor

   More actions

   Thank you for your feedback. We've done some work on the Architecture doc. We've expanded the information about NgModules in #21569. Does this sufficiently address this potential point of confusion?
5. jenniferfell

   assigned

   jbogarthyde

   on Feb 15, 2018
6. jenniferfell

   added

   effort1: hours

   freq3: high

   severity1: confusing

   on Feb 15, 2018
7. jenniferfell

   assigned

   jenniferfell

   and unassigned

   jbogarthyde

   on Feb 15, 2018
8. ngbot

   added this to the needsTriage milestone on Feb 26, 2018
9. jenniferfell commented on May 25, 2018

   

   jenniferfell

   on May 25, 2018

   Contributor

   More actions

   Rechecked against v6. Keeping open.

   @trotyl recommendation would be a useful clarification to help differentiate between "You import NgModule" (a proper noun) and "you import any ngModule" (kind of thing, which is the intent here).

   Recommendation copied here for convenience: "You also import NgModules (eg. BrowserModule) from Angular libraries using JavaScript import statements."
10. jenniferfell

    assigned

    jbogarthyde

    on May 25, 2018
11. jenniferfell

    added

    featureLabel used to distinguish feature request from other issuesLabel used to distinguish feature request from other issues

    subtype: docs-clarification

    on May 25, 2018
12. 7 remaining items
13. mhevery

    added a commit that references this issue on Jul 10, 2018

    docs: clarify wording in architecture overview (#24481)

    This issue will close once commit 8887d75 is merged into the 'main' branch.

    8887d75
14. mhevery

    closed this as completedin e1146f3on Jul 10, 2018
15. IgorMinar

    added 2 commits that reference this issue on Jul 30, 2018

    docs: refactor pipe example to use the HttpClient (#22741)

    This issue will close once commit 5399c17 is merged into the 'main' branch.

    5399c17
16. angular-automatic-lock-bot commented on Sep 13, 2019

    

    angular-automatic-lock-botBot

    on Sep 13, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
17. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 13, 2019

Issue actions