GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — google3 CI check seems to consider only the last commit and not the PR diff · Issue #22871 · angular/angular

google3 CI check seems to consider only the last commit and not the PR diff #22871

New issue
Copy link
New issue
Copy link
Closed
Closed
google3 CI check seems to consider only the last commit and not the PR diff#22871
Copy link
Labels
area: build & ciRelated the build and CI infrastructure of the projectRelated the build and CI infrastructure of the projecttype: bug/fix
Milestone
needsTriage

Description

@IgorMinar
IgorMinar
opened on Mar 20, 2018
Issue body actions

While working on the rxjs v6 update PR #22573 I noticed that the g3 CI check suddenly claimed that the PR had no impact on g3 (it had). This check was working just fine until I pushed a last commit to the branch that had no impact on g3 - that makes me suspect that the check operates only on the last commit and not the diff between master and the PR HEAD.

Screenshot:

screen shot 2018-03-19 at 9 09 05 pm

Activity

  1. ngbot
    added this to the needsTriage milestone on Mar 20, 2018
  2. IgorMinar
    added
    type: bug/fix
    area: build & ciRelated the build and CI infrastructure of the projectRelated the build and CI infrastructure of the project
    on Mar 20, 2018
  3. jelbourn commented on Oct 16, 2020

    @jelbourn
    jelbourn
    on Oct 16, 2020
    Contributor
    More actions

    Closing since this seems to be obsolete (Andrew Scott says it definitely checks the whole PR)

  4. jelbourn
    closed this as completedon Oct 16, 2020
  5. angular-automatic-lock-bot commented on Nov 16, 2020

    @angular-automatic-lock-bot
    angular-automatic-lock-botBot
    on Nov 16, 2020
    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  6. angular-automatic-lock-bot
    locked and limited conversation to collaborators on Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: build & ciRelated the build and CI infrastructure of the projectRelated the build and CI infrastructure of the projecttype: bug/fix

    Type

    No type

    Projects

    No projects

      Milestone

      • needsTriageNo due date

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.