GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(router): add routing to async components by btford · Pull Request #2165 · angular/angular

Conversation

@btford

@btford btford commented May 26, 2015

Copy link
Copy Markdown
Contributor

This lays the groundwork for lazy loading in Angular 2.

I'm still working on the API + Docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vsavkin vsavkin added the in progress label May 26, 2015
@googlebot googlebot added the cla: yes label May 26, 2015
@btford btford added !needs_docs labels May 26, 2015
@mhevery mhevery assigned IgorMinar May 28, 2015
@mhevery

mhevery commented May 28, 2015

Copy link
Copy Markdown
Contributor

@IgorMinar please review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@btford btford added this to the M9: TypeScript and Build Stability milestone May 28, 2015
@mhevery mhevery added P1: urgent and removed in progress labels May 29, 2015
@mhevery mhevery modified the milestone: M9: TypeScript and Build Stability May 29, 2015
@btford

btford commented May 29, 2015

Copy link
Copy Markdown
Contributor Author

We're going to prioritize #2001 over this, so hold off until after the router is typescriptified since I'll have to rewrite/rebase this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@btford btford mentioned this pull request May 29, 2015
TypeScript-ify: router #2001
Closed
@tbosch tbosch added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 1, 2015
@btford
feat(facade): add isMap method
95ab3a0
@btford
btford force-pushed the feat-async-recognition branch 2 times, most recently from 257905c to ebb5bba Compare June 8, 2015 20:59
@btford
feat(router): add routing to async components
e552080 
Note that this also removes the `components` option from `RouteConfig`.
This functionality will be reintroduced with the more general `//` routing.
See angular#2329 for more details.
@btford
btford force-pushed the feat-async-recognition branch from ebb5bba to e552080 Compare June 8, 2015 21:15
@btford

btford commented Jun 8, 2015

Copy link
Copy Markdown
Contributor Author

Landed as 548f3dd and cd95e07.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@btford btford closed this Jun 8, 2015
@jpsfs

jpsfs commented Jul 20, 2015

Copy link
Copy Markdown

Hi,

Sorry to dig up this.

I'm doing some experiences with routing and lazy loaded components. Right now the only examples I'm seeing require something like:

´´´
import {MyComponent} from "mypackage";

@RouteConfig([
{ path: '/', component: MyComponent, as 'start'}
])
´´´

Now, what I don't want to load MyComponent until I absolutely need to. Is there any way of doing something like:

´´´
@RouteConfig([
{ path: '/', component: 'mypackage/MyComponent', as 'start'}
])
´´´

Cheers,
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@btford
btford deleted the feat-async-recognition branch October 23, 2015 13:04
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 7, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@IgorMinar IgorMinar

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@btford @mhevery @jpsfs @matsko @vsavkin @IgorMinar @tbosch @googlebot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.