GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs(architecture): Change hero-detail reference to app-hero-detail by wimgoeman · Pull Request #21957 · angular/angular

Conversation

@wimgoeman

@wimgoeman wimgoeman commented Feb 1, 2018

Copy link
Copy Markdown

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #21955

What is the new behavior?

Documentation corrected as described in issue. Now app-hero-detail is used.

Does this PR introduce a breaking change?

[ ] Yes
[X ] No

Other information

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@wimgoeman
docs(architecture): Change hero-detail reference to app-hero-detail
cefe523
@googlebot

googlebot commented Feb 1, 2018

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@googlebot googlebot added the cla: no label Feb 1, 2018
@gkalpak gkalpak added the comp: docs label Feb 1, 2018
@jenniferfell

jenniferfell commented Feb 2, 2018

Copy link
Copy Markdown
Contributor

@wimgoeman Thanks for submitting this fix. We've been doing some parallel work on the architecture section, and we're very close to releasing that update.

Would you be willing to do us a favor and check the new "Architecture - Introduction to Components" section and see if we've correctly referred to app-hero-detail? Filename architecture-components on this PR: #21569

Thank you again for your contribution!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jenniferfell
jenniferfell requested a review from jbogarthyde February 2, 2018 00:58
@jenniferfell jenniferfell mentioned this pull request Feb 2, 2018
docs(aio): update architecture section #21569
Closed
1 of 3 tasks
@ngbot

ngbot Bot commented Mar 19, 2018

Copy link
Copy Markdown

Hi @wimgoeman! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jenniferfell jenniferfell added the state: community Someone from the Angular community is working on this issue or submitted this PR label Jul 23, 2018
@brandonroberts

brandonroberts commented Aug 2, 2018

Copy link
Copy Markdown
Contributor

Thanks for the PR @wimgoeman! This has already been fixed in master but if you see something else, open a new PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brandonroberts brandonroberts closed this Aug 2, 2018
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jbogarthyde jbogarthyde Awaiting requested review from jbogarthyde

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cla: no state: community Someone from the Angular community is working on this issue or submitted this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@wimgoeman @googlebot @jenniferfell @brandonroberts @gkalpak
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.