GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(router): workaround issues in closure compiler by vikerman · Pull Request #22870 · angular/angular

Conversation

@vikerman

@vikerman vikerman commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

Spread operator in this particular place was throwing off closure(probably because it was thrown off by the of in the source).

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Current Angular code doesn't compile with certain closure compiler flag

What is the new behavior?

Works with closure

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vikerman
fix(router): workaround issues in closure compiler
fcb46cc 
Spread operator in this particular place was throwing off closure(probably because it was thrown off by the `of` in the source).
@googlebot googlebot added the cla: yes label Mar 19, 2018
@vikerman
vikerman requested a review from IgorMinar March 19, 2018 23:05
@vikerman vikerman added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 19, 2018
@mary-poppins

mary-poppins commented Mar 19, 2018

Copy link
Copy Markdown

You can preview fcb46cc at https://pr22870-fcb46cc.ngbuilds.io/.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
IgorMinar
IgorMinar suggested changes Mar 19, 2018
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #22573 I rewrote this to:

+  return of (...waitHead, ...waitTail).pipe(concatAll(), lastValue(), map(() => res));

will this still be problematic? In the meantime I suggest we don't merge this as is. If needed I can cherry-pick this to my PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@IgorMinar

IgorMinar commented Mar 20, 2018

Copy link
Copy Markdown
Contributor

I verified that this is no longer a problem with #22573. closing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@IgorMinar IgorMinar closed this Mar 20, 2018
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@IgorMinar IgorMinar IgorMinar requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vikerman @mary-poppins @IgorMinar @googlebot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.