GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: typescript 2.9 support by IgorMinar · Pull Request #24652 · angular/angular

Conversation

@IgorMinar

@IgorMinar IgorMinar commented Jun 25, 2018 •
edited by mhevery
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

known issues:

  • one of the e2e tests are failing because of somehow we don't generate proper amd modules within bazel pipeline. This might be a tsickle 0.30.0 issues. I'm not sure. @alexeagle could you help plz?
  • one of the tests for the compiler's metadata compiler is failing. it seems to me that the new behavior is actually correct, but I'd like a clarification from @alxhub plz
  • there is one more failing test from the runtime I haven't investigated this yet. - the issue identified with a runtime error due to undefined "selector" property seems to be a breakage in the master/HEAD and unrelated to my change.
  • the pr needs to be reformatted

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nicolashenry, sylvaindumont, Bnaya, alan-agius4, itsdevdom, Rodrigo54, ericmartinezr, reduckted, micksatana, Xceno, and 9 more reacted with thumbs up emoji alan-agius4, lacolaco, otodockal, treeder, CharlBest, abraham, and ahnpnl reacted with heart emoji
All reactions
  • 👍 19 reactions
  • ❤️ 7 reactions
@googlebot googlebot added the cla: yes label Jun 25, 2018
@IgorMinar

IgorMinar commented Jun 25, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@fyi: @mprobst, @mhevery, @manughub
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mprobst

mprobst commented Jun 25, 2018

Copy link
Copy Markdown
Contributor

Nice!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JoostK
JoostK reviewed Jun 25, 2018
View reviewed changes
Comment thread packages/compiler-cli/test/metadata/collector_spec.ts Outdated

@JoostK JoostK Jun 25, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, nice one but still incorrect :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sandangel, skreborn, ericmartinezr, SebastianPodgajny, alan-agius4, FDIM, alfaproject, itsdevdom, michaelbromley, and trotyl reacted with thumbs up emoji
All reactions
  • 👍 10 reactions

@mhevery mhevery Jun 27, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericmartinezr ericmartinezr mentioned this pull request Jun 25, 2018
Add support for TypeScript 2.8 #23779
Closed
6 of 7 tasks
@EatonZ

EatonZ commented Jun 25, 2018

Copy link
Copy Markdown

Just an FYI.. you have 2.10 in a few spots here. The next version is actually 3.0.
alan-agius4, ericmartinezr, sandangel, vitalybibikov, and tplk reacted with thumbs up emoji
All reactions
  • 👍 5 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhevery mhevery self-assigned this Jun 26, 2018
@mprobst

mprobst commented Jun 27, 2018

Copy link
Copy Markdown
Contributor

@IgorMinar what's the status of this? We'd like to move google3 to TS2.9 and are blocked on this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhevery

mhevery commented Jun 27, 2018

Copy link
Copy Markdown
Contributor

Since @IgorMinar is on vacation, I will take over this PR.
nicolashenry, sarunint, and egorshulga reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhevery
mhevery force-pushed the build/tsc-2.9 branch from ea3e466 to 2363ee3 Compare June 27, 2018 21:57
@mhevery mhevery added the target: major This PR is targeted for the next major release label Jun 27, 2018
mhevery
mhevery approved these changes Jun 27, 2018
View reviewed changes
@googlebot

googlebot commented Jun 27, 2018

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@googlebot googlebot added cla: no and removed cla: yes labels Jun 27, 2018
@mhevery mhevery added cla: yes and removed cla: no labels Jun 27, 2018
@googlebot

googlebot commented Jun 27, 2018

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@googlebot

googlebot commented Jun 28, 2018

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@googlebot googlebot added cla: no and removed cla: yes labels Jun 28, 2018
@mhevery mhevery added cla: yes and removed cla: no labels Jun 28, 2018
@googlebot

googlebot commented Jun 28, 2018

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhevery

mhevery commented Jun 28, 2018

Copy link
Copy Markdown
Contributor

Blocked on angular/tsickle#846
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@googlebot

googlebot commented Jun 28, 2018

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@googlebot googlebot added cla: no and removed cla: yes labels Jun 28, 2018
@mhevery mhevery added cla: yes and removed cla: no labels Jun 28, 2018
mhevery and others added 9 commits July 3, 2018 10:13
@mhevery
fixup! feat: typescript 2.9 support
5644f8a
@mhevery
fixup! feat: typescript 2.9 support
a45cf8f
@mhevery
fixup! feat: typescript 2.9 support
cca48b1
@mhevery
fixup! feat: typescript 2.9 support
2d95444
@mhevery
fixup! feat: typescript 2.9 support
ba436b2
@mhevery
fixup! feat: typescript 2.9 support
7ddf824
@mhevery
fixup! feat: typescript 2.9 support
955e543
@mhevery
fixup! feat: typescript 2.9 support
db222e6
@alxhub @mhevery
fixup! feat: typescript 2.9 support
e601954
@mhevery
mhevery force-pushed the build/tsc-2.9 branch from 1518e91 to e601954 Compare July 3, 2018 17:13
@mhevery mhevery added cla: yes and removed cla: no labels Jul 3, 2018
@googlebot

googlebot commented Jul 3, 2018

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhevery

mhevery commented Jul 3, 2018

Copy link
Copy Markdown
Contributor

http://test/OCL:203143205:BASE:203143231:1530638557253:a92f7ca2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mary-poppins

mary-poppins commented Jul 3, 2018

Copy link
Copy Markdown

You can preview e601954 at https://pr24652-e601954.ngbuilds.io/.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alxhub
fixup! feat: typescript 2.9 support
fd69070
@googlebot

googlebot commented Jul 3, 2018

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@googlebot googlebot added cla: no and removed cla: yes labels Jul 3, 2018
@alxhub
fixup! feat: typescript 2.9 support
5331d1b
@mary-poppins

mary-poppins commented Jul 3, 2018

Copy link
Copy Markdown

You can preview fd69070 at https://pr24652-fd69070.ngbuilds.io/.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mary-poppins

mary-poppins commented Jul 3, 2018

Copy link
Copy Markdown

You can preview 5331d1b at https://pr24652-5331d1b.ngbuilds.io/.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alxhub alxhub added cla: yes and removed cla: no labels Jul 3, 2018
@googlebot

googlebot commented Jul 3, 2018

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhevery mhevery closed this in e3064d5 Jul 3, 2018
cexbrayat
cexbrayat reviewed Jul 3, 2018
View reviewed changes
Comment thread integration/typings_test_ts29/package.json
"@angular/upgrade": "file:../../dist/packages-dist/upgrade",
"@types/jasmine": "2.5.41",
"rxjs": "file:../../node_modules/rxjs",
"typescript": "2.8.x",

@cexbrayat cexbrayat Jul 3, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhevery Is it not weird to have 2.8.x in the package.json of typings_test_ts29. Shouldn't that be 2.9.x (and in the description above)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@cexbrayat cexbrayat Jul 3, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #24749 to fix it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mhevery mhevery Jul 6, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, and thanks for the fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK left review comments
@alxhub alxhub alxhub approved these changes
+3 more reviewers
@mhevery mhevery mhevery approved these changes
@cexbrayat cexbrayat cexbrayat left review comments
@eduardocereto eduardocereto eduardocereto requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mhevery mhevery

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@IgorMinar @mprobst @EatonZ @mhevery @googlebot @mary-poppins @mgol @eduardocereto @JoostK @cexbrayat @alxhub
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.