GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(http): improve error message for nullish header by markostanimirovic · Pull Request #46059 · angular/angular

Conversation

@markostanimirovic

@markostanimirovic markostanimirovic commented May 19, 2022

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #46048

What is the new behavior?

Improved error message for nullish headers.

Does this PR introduce a breaking change?

  • Yes
  • No

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pullapprove
pullapprove Bot requested a review from AndrewKushnir May 19, 2022 10:53
@markostanimirovic
markostanimirovic force-pushed the feat/http/nullish-header-error-message branch from 0bee9b2 to bbc0bd0 Compare May 19, 2022 11:25
@alxhub alxhub added the area: common/http Issues related to HTTP and HTTP Client label May 25, 2022
@ngbot ngbot Bot added this to the Backlog milestone May 25, 2022
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 9, 2022
@markostanimirovic
markostanimirovic force-pushed the feat/http/nullish-header-error-message branch 2 times, most recently from 6a77b4b to 98fa657 Compare June 14, 2022 21:03
AndrewKushnir
AndrewKushnir requested changes Jun 14, 2022
View reviewed changes
Comment thread packages/common/http/src/headers.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
AndrewKushnir
AndrewKushnir reviewed Jun 15, 2022
View reviewed changes
Comment thread packages/common/http/src/headers.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread packages/common/http/test/headers_spec.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@markostanimirovic
feat(http): improve error message for nullish header
c646140 
This commit improves the error message for nullish headers.

Fixes angular#46048
@markostanimirovic
markostanimirovic force-pushed the feat/http/nullish-header-error-message branch from 98fa657 to c646140 Compare June 15, 2022 21:11
@markostanimirovic
markostanimirovic requested a review from AndrewKushnir June 15, 2022 21:45
AndrewKushnir
AndrewKushnir approved these changes Jun 16, 2022
View reviewed changes

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markostanimirovic thanks for addressing the feedback. The change looks good 👍

I've also ran tests in Google's codebase (internal link) and they came back as "green".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markostanimirovic reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 16, 2022
@AndrewKushnir

AndrewKushnir commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 82acbf9.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AndrewKushnir AndrewKushnir closed this in 82acbf9 Jun 16, 2022
This was referenced Jul 1, 2022
build(deps-dev): bump @angular/language-service from 12.2.4 to 14.0.4 numbersprotocol/capture-cam#1761
Closed
build(deps-dev): bump @angular/compiler from 12.2.4 to 14.0.4 numbersprotocol/capture-cam#1755
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jul 17, 2022

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markostanimirovic @AndrewKushnir @alxhub
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.