GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(core): make parent injector argument required in `createEnvironmentInjector` by AndrewKushnir · Pull Request #46397 · angular/angular

Conversation

@AndrewKushnir

@AndrewKushnir AndrewKushnir commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

Previously, the createEnvironmentInjector function allowed creating an instance of an EnvironmentInjector without providing a parent injector. This resulted in an injector instance, which was detached from the DI tree, thus having limited value. This commit updates the types of the createEnvironmentInjector function to make the parent injector a required argument.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No. The createEnvironmentInjector API is in the Developer Preview phase (and it's marked as such), so this change can be included into the patch branch.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Jun 16, 2022
@AndrewKushnir
AndrewKushnir requested a review from alxhub June 16, 2022 22:12
@ngbot ngbot Bot added this to the Backlog milestone Jun 16, 2022
@pullapprove
pullapprove Bot requested review from atscott and dylhunn June 16, 2022 22:13
atscott
atscott approved these changes Jun 16, 2022
View reviewed changes

@atscott atscott left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread packages/core/test/acceptance/standalone_spec.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AndrewKushnir
AndrewKushnir force-pushed the env-injector-require-parent branch from 13bacde to 5e30ac4 Compare June 16, 2022 22:40
alxhub
alxhub approved these changes Jun 16, 2022
View reviewed changes
@pullapprove
pullapprove Bot requested a review from pkozlowski-opensource June 16, 2022 23:00
@AndrewKushnir

AndrewKushnir commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

Presubmit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Jun 16, 2022
atscott
atscott reviewed Jun 16, 2022
View reviewed changes
Comment thread packages/core/test/acceptance/di_spec.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pullapprove
pullapprove Bot requested a review from alxhub June 16, 2022 23:04
@AndrewKushnir AndrewKushnir added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 16, 2022
@AndrewKushnir
fix(core): make parent injector argument required in `createEnvironme…
e5ccc04 
…ntInjector`

Previously, the `createEnvironmentInjector` function allowed creating an instance of an EnvironmentInjector without providing a parent injector. This resulted in an injector instance, which was detached from the DI tree, thus having limited value. This commit updates the types of the `createEnvironmentInjector` function to make the parent injector a required argument.
@AndrewKushnir
AndrewKushnir force-pushed the env-injector-require-parent branch from 5e30ac4 to e5ccc04 Compare June 16, 2022 23:14
alxhub
alxhub approved these changes Jun 16, 2022
View reviewed changes
@pullapprove
pullapprove Bot requested a review from alxhub June 16, 2022 23:37
alxhub
alxhub approved these changes Jun 16, 2022
View reviewed changes

@alxhub alxhub left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pkozlowski-opensource
pkozlowski-opensource approved these changes Jun 17, 2022
View reviewed changes

@pkozlowski-opensource pkozlowski-opensource left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Jun 17, 2022
@AndrewKushnir

AndrewKushnir commented Jun 17, 2022

Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository by commit bb7c804.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AndrewKushnir AndrewKushnir closed this in bb7c804 Jun 17, 2022
This was referenced Jul 1, 2022
build(deps-dev): bump @angular/language-service from 12.2.4 to 14.0.4 numbersprotocol/capture-cam#1761
Closed
build(deps-dev): bump @angular/compiler from 12.2.4 to 14.0.4 numbersprotocol/capture-cam#1755
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jul 18, 2022

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes
@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes
@alxhub alxhub alxhub approved these changes
@dylhunn dylhunn Awaiting requested review from dylhunn

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AndrewKushnir @atscott @pkozlowski-opensource @alxhub
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.